fix: optimize scroll position observer after video fullscreen exit #1370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request contains an optimization for toggling video xblock full-screen mode and saving the previous window top offset position on exit from the full-screen state.
With this refactor, we call
scroll
after exit full-screen mode only and not depends on xblock resize because sometimes the resize event comes before exiting full screen mode, and we don't need to call scroll every time on resize.Related PR to master branch: #1371
Related PR to redwood branch: #1405