Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize scroll position observer after video fullscreen exit #1370

Conversation

ihor-romaniuk
Copy link
Contributor

@ihor-romaniuk ihor-romaniuk commented Apr 25, 2024

This merge request contains an optimization for toggling video xblock full-screen mode and saving the previous window top offset position on exit from the full-screen state.

With this refactor, we call scroll after exit full-screen mode only and not depends on xblock resize because sometimes the resize event comes before exiting full screen mode, and we don't need to call scroll every time on resize.

Related PR to master branch: #1371
Related PR to redwood branch: #1405

@openedx-webhooks
Copy link

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@ihor-romaniuk ihor-romaniuk force-pushed the romaniuk/optimize-scroll-position-observer branch from f818307 to a7700f8 Compare April 25, 2024 09:15
@itsjeyd itsjeyd added the backport PR backports a change from main to a named release. label May 23, 2024
@itsjeyd
Copy link

itsjeyd commented May 31, 2024

OSPR management note: Build seems fine except for codecov token issues. Marking as ready for review.

@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label May 31, 2024
@itsjeyd itsjeyd requested review from arbrandes and removed request for leangseu-edx and BrandonHBodine June 6, 2024 07:42
@arbrandes arbrandes merged commit 37c28b6 into openedx:open-release/quince.master Jun 6, 2024
3 of 4 checks passed
@openedx-webhooks
Copy link

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants