Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize scroll position observer after video fullscreen exit #1371

Conversation

ihor-romaniuk
Copy link
Contributor

This merge request contains an optimization for toggling video xblock full-screen mode and saving the previous window top offset position on exit from the full-screen state.

With this refactor, we call scroll after exit full-screen mode only and not depends on xblock resize because sometimes the resize event comes before exiting full screen mode, and we don't need to call scroll every time on resize.

Related PR to quince branch: #1370

@openedx-webhooks
Copy link

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@ihor-romaniuk ihor-romaniuk force-pushed the romaniuk/optimize-scroll-position-observer-master branch from c7cb0bb to 79f0b6a Compare April 25, 2024 09:17
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.28%. Comparing base (72381a7) to head (79f0b6a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1371   +/-   ##
=======================================
  Coverage   88.28%   88.28%           
=======================================
  Files         292      292           
  Lines        5002     5002           
  Branches     1269     1269           
=======================================
  Hits         4416     4416           
  Misses        570      570           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itsjeyd
Copy link

itsjeyd commented May 23, 2024

Hey @ihor-romaniuk, thank you for this contribution! I marked it as ready for review, but let me know if you were planning to work on the changes some more.

Copy link

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@arbrandes arbrandes merged commit 9437142 into openedx:master May 30, 2024
7 checks passed
@openedx-webhooks
Copy link

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd
Copy link

itsjeyd commented May 31, 2024

Hey @arbrandes, would you mind giving the Quince backport for this PR (#1370) a quick look, too?

@ihor-romaniuk ihor-romaniuk deleted the romaniuk/optimize-scroll-position-observer-master branch June 3, 2024 08:55
@ihor-romaniuk
Copy link
Contributor Author

@arbrandes and also take a look at Redwood backport PR #1405, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants