Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate notification tray in learning header #379

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

awais-ansari
Copy link
Contributor

INF-993

  • Remove notification module from openedx header because there is a plan to extract this module to npm package.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -17.54% ⚠️

Comparison is base (4b89e75) 78.79% compared to head (018ca18) 61.25%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #379       +/-   ##
===========================================
- Coverage   78.79%   61.25%   -17.54%     
===========================================
  Files          31       16       -15     
  Lines         599      302      -297     
  Branches      112       70       -42     
===========================================
- Hits          472      185      -287     
+ Misses        124      115        -9     
+ Partials        3        2        -1     
Files Changed Coverage Δ
src/learning-header/AuthenticatedUserDropdown.jsx 83.33% <ø> (-8.98%) ⬇️
src/learning-header/LearningHeader.jsx 92.85% <75.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awais-ansari awais-ansari merged commit 464e952 into master Aug 2, 2023
4 of 5 checks passed
@awais-ansari awais-ansari deleted the aansari/INF-993 branch August 2, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants