-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional OpenFAAS chart #57
Conversation
Thanks for the pull request, @gabor-boros! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
2 similar comments
Thanks for the pull request, @gabor-boros! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Thanks for the pull request, @gabor-boros! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@@ -10,9 +10,13 @@ that the load balancer is working. First, get its external IP using | |||
Next, go to http://the.external.ip.shown/cluster-echo-test and make sure you get | |||
a JSON response. | |||
|
|||
{{- if .Values.openfaas.enabled }} | |||
OpenFAAS is enabled. The default admin user password is automatically generated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this statement link out to documentation showing some examples of how OpenFaas could be used or providing details on how to add a function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although this could, I'm not convinced that the Harmony chart should contain "tutorial"/educational content. I mean, if someone enables OpenFAAS, probably the reason is that he/she knows why it is going to be enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think OpenFaas is a great tool for hosting logic that glues things together. I am curious which things might make sense to use OpenFaas vs jobs vs something heavier like Argo Wrokflows and Argo Events. I also think this PR should include a change to https://github.com/openedx/openedx-k8s-harmony?tab=readme-ov-file#technology-stack-and-architecture detailing the newly togglable feature.
values-minikube.yaml
Outdated
@@ -22,3 +22,6 @@ opensearch: | |||
|
|||
persistence: | |||
size: 8Gi | |||
|
|||
openfaas: | |||
enabled: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a new empty line at the end of the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 added!
charts/harmony-chart/Chart.yaml
Outdated
@@ -52,3 +52,9 @@ dependencies: | |||
version: "v0.29.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to bump the version of the harmony chart to trigger a new release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Would you like me to bump before or after review?
fc087fe
to
b881c36
Compare
@gabor-boros Hi, could you please rebase these changes please? |
Hi @gabor-boros! Friendly ping on this. |
@jfavellar90 I missed the ping here. Sorry. Will rebase tomorrow. |
b881c36
to
48d179b
Compare
Signed-off-by: Gabor Boros <[email protected]>
48d179b
to
296ea2a
Compare
@jfavellar90 Rebased and squashed the commits. Now it should be good for a final approval & merge. |
@jfavellar90 a gentle reminder here 😇 |
@gabor-boros 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This PR resolves #53 by adding an optional OpenFAAS chart to the dependencies.
Example configuration: