Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional OpenFAAS chart #57

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Add optional OpenFAAS chart #57

merged 1 commit into from
Apr 15, 2024

Conversation

gabor-boros
Copy link
Contributor

This PR resolves #53 by adding an optional OpenFAAS chart to the dependencies.

Screenshot 2023-12-30 at 12 56 35

Example configuration:

openfaas:
  enabled: true
  ingress:
    enabled: false
    hosts:
      - host: gateway.openfaas.local  # Replace with gateway.example.com if public-facing
        serviceName: gateway
        servicePort: 8080
        path: /
    annotations:
      kubernetes.io/ingress.class: nginx
      cert-manager.io/cluster-issuer: letsencrypt-prod
      nginx.ingress.kubernetes.io/ssl-redirect: "true" 
      nginx.ingress.kubernetes.io/force-ssl-redirect: "true"

@gabor-boros gabor-boros added awaiting prioritization waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Dec 30, 2023
@gabor-boros gabor-boros self-assigned this Dec 30, 2023
@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U labels Dec 30, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @gabor-boros! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

2 similar comments
@openedx-webhooks
Copy link

Thanks for the pull request, @gabor-boros! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks
Copy link

Thanks for the pull request, @gabor-boros! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@@ -10,9 +10,13 @@ that the load balancer is working. First, get its external IP using
Next, go to http://the.external.ip.shown/cluster-echo-test and make sure you get
a JSON response.

{{- if .Values.openfaas.enabled }}
OpenFAAS is enabled. The default admin user password is automatically generated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this statement link out to documentation showing some examples of how OpenFaas could be used or providing details on how to add a function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this could, I'm not convinced that the Harmony chart should contain "tutorial"/educational content. I mean, if someone enables OpenFAAS, probably the reason is that he/she knows why it is going to be enabled.

values.yaml Outdated Show resolved Hide resolved
values.yaml Outdated Show resolved Hide resolved
Copy link

@adzuci adzuci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think OpenFaas is a great tool for hosting logic that glues things together. I am curious which things might make sense to use OpenFaas vs jobs vs something heavier like Argo Wrokflows and Argo Events. I also think this PR should include a change to https://github.com/openedx/openedx-k8s-harmony?tab=readme-ov-file#technology-stack-and-architecture detailing the newly togglable feature.

@@ -22,3 +22,6 @@ opensearch:

persistence:
size: 8Gi

openfaas:
enabled: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a new empty line at the end of the file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 added!

@@ -52,3 +52,9 @@ dependencies:
version: "v0.29.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to bump the version of the harmony chart to trigger a new release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Would you like me to bump before or after review?

@jfavellar90
Copy link
Contributor

@gabor-boros Hi, could you please rebase these changes please?

@mphilbrick211
Copy link

@gabor-boros Hi, could you please rebase these changes please?

Hi @gabor-boros! Friendly ping on this.

@mphilbrick211 mphilbrick211 removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Mar 20, 2024
@gabor-boros
Copy link
Contributor Author

@jfavellar90 I missed the ping here. Sorry. Will rebase tomorrow.

Signed-off-by: Gabor Boros <[email protected]>
@gabor-boros
Copy link
Contributor Author

@jfavellar90 Rebased and squashed the commits. Now it should be good for a final approval & merge.

@gabor-boros
Copy link
Contributor Author

@jfavellar90 a gentle reminder here 😇

@gabor-boros gabor-boros merged commit 1483d0f into main Apr 15, 2024
2 checks passed
@gabor-boros gabor-boros deleted the gabor/add-openfaas branch April 15, 2024 10:32
@openedx-webhooks
Copy link

@gabor-boros 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add optional openfaas to chart
5 participants