Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional OpenFAAS chart #57

Merged
merged 1 commit into from
Apr 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions charts/harmony-chart/Chart.lock
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,8 @@ dependencies:
- name: velero
repository: https://vmware-tanzu.github.io/helm-charts
version: 5.2.0
digest: sha256:b26b5db88f71eac11257f2f9f4a8f2999738f67456779fb204b9ca593b7f0de3
generated: "2024-03-25T11:47:55.141915+04:00"
- name: openfaas
repository: https://openfaas.github.io/faas-netes
version: 14.2.34
digest: sha256:17908dd6f2ea4df87042d4bad904965cd4c77e637429acdf1a2a5c1256f85586
generated: "2024-04-03T18:29:03.753422+04:00"
7 changes: 6 additions & 1 deletion charts/harmony-chart/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes to the chart and its
# templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.6.0
version: 0.7.0
# This is the version number of the application being deployed. This version number should be incremented each time you
# make changes to the application. Versions are not expected to follow Semantic Versioning. They should reflect the
# version the application is using. It is recommended to use it with quotes.
Expand Down Expand Up @@ -69,3 +69,8 @@ dependencies:
version: "5.2.0"
repository: https://vmware-tanzu.github.io/helm-charts
condition: velero.enabled

- name: openfaas
version: "14.2.34"
repository: https://openfaas.github.io/faas-netes
condition: openfaas.enabled
6 changes: 6 additions & 0 deletions charts/harmony-chart/templates/NOTES.txt
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,13 @@ Now you can connect to https://localhost:8443. The certificate is self-signed by
the cluster.
{{- end }}

{{- if .Values.openfaas.enabled }}
OpenFAAS is enabled. The default admin user password is automatically generated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this statement link out to documentation showing some examples of how OpenFaas could be used or providing details on how to add a function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this could, I'm not convinced that the Harmony chart should contain "tutorial"/educational content. I mean, if someone enables OpenFAAS, probably the reason is that he/she knows why it is going to be enabled.

for you by default, and available a secret, called "basic-auth". You can
retrieve the password by using

kubectl -n {{ .Release.Namespace }} get secret --template='{{"{{"}}index .data "basic-auth-password"{{"}}"}}' basic-auth
{{- end }}

{{- /*

Expand Down
9 changes: 9 additions & 0 deletions charts/harmony-chart/templates/openfaas/namespace.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{{- if .Values.openfaas.enabled -}}
apiVersion: v1
kind: Namespace
metadata:
labels:
kubernetes.io/metadata.name: openfaas-fn
name: openfaas-fn
name: openfaas-fn
{{- end }}
3 changes: 3 additions & 0 deletions charts/harmony-chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -370,3 +370,6 @@ velero:
schedule: "59 23 * * 0"
template:
ttl: "720h"

openfaas:
enabled: false
3 changes: 3 additions & 0 deletions values-example.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -86,3 +86,6 @@ velero:
volumeMounts:
- mountPath: /target
name: plugins

openfaas:
enabled: false
3 changes: 3 additions & 0 deletions values-minikube.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,6 @@ prometheusstack:

k8sdashboard:
enabled: false

openfaas:
enabled: false