Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] fix: truncating a whole text #2584

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

khudym
Copy link
Contributor

@khudym khudym commented Aug 31, 2023

Description

  • Fixed issue with truncating a whole string without spaces by adding 'word-break: break-word' style.
    This style is added to the newElement which is a copy of element on which all calculations are made.

Issue

Deploy Preview

Truncate

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Aug 31, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @khudym!

When this pull request is ready, tag your edX technical lead.

@netlify
Copy link

netlify bot commented Aug 31, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b173666
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/6502d7b66d08c40008b3188e
😎 Deploy Preview https://deploy-preview-2584--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/Truncate/utils.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.11% 🎉

Comparison is base (287a5e8) 91.70% compared to head (b173666) 91.81%.
Report is 26 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2584      +/-   ##
==========================================
+ Coverage   91.70%   91.81%   +0.11%     
==========================================
  Files         236      235       -1     
  Lines        4219     4217       -2     
  Branches     1021     1020       -1     
==========================================
+ Hits         3869     3872       +3     
+ Misses        346      341       -5     
  Partials        4        4              
Files Changed Coverage Δ
src/Truncate/utils.js 100.00% <ø> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viktorrusakov viktorrusakov merged commit 3db63e7 into openedx:master Sep 14, 2023
9 checks passed
@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 21.1.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

@openedx-webhooks
Copy link

@khudym 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 22.0.0-alpha.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released on @alpha released
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

[paragon-openedx.netlify.app] Feedback (on /components/truncate/)
7 participants