-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: separate files for different test cases #128
test: separate files for different test cases #128
Conversation
@sarayusreeyadavpadala awesome to see your contributions. I don't have time to review right now but I will maybe next week (if @aadarsh-ram does not have the time in-between). |
@alexgarel No problem, take your time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarayusreeyadavpadala Initial comments please use "make lint"
@sumit-158 Kindly elaborate further on what you have just said. |
Hi @sarayusreeyadavpadala! Thank you for the contributions. Currently, your PR is failing workflows, related to code quality and linting. Please use the |
Thank you @aadarsh-ram |
@aadarsh-ram, @sumit-158 Could you please check my new commit once.... |
@sarayusreeyadavpadala Seems like the Linting is not fixed yet :-) , make sure to use |
Thank you @sumit-158 |
@sumit-158 when I run "make lint" command, it shows- |
@stephanegigandet Can you use Slack for further discussion? Join us in the channel |
I have sorted the imports using "isort" this time. And also used "black". |
Could anyone approve the workflows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sarayusreeyadavpadala good work, I have made a push for the lint issue, and now it is resolved but tests are failing, please look into it :-)
tip: use docker-compose run --rm --no-deps facets-api pytest -vv .
to see the total output of tests and why and where it is failing
Thank you @sumit-158 I'll do that. |
Hey there! I am a beginner to Open Source and I am interested to contribute to Open Food Facts. Here, I've separated the test cases into different files and deleted the existing file. Let me know if any changes are needed. Looking forward to your suggestions.