Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: separate files for different test cases #128

Closed
wants to merge 4 commits into from
Closed

test: separate files for different test cases #128

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c3e7c1
test files were modified
sarayusreeyadavpadala Sep 23, 2023
5d120c2
fix: lint
sumit-158 Sep 25, 2023
d12f3d9
Update pull_request.yml
sarayusreeyadavpadala Sep 29, 2023
8d7b2ad
pull_request.yml
sarayusreeyadavpadala Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
326 changes: 326 additions & 0 deletions tests/test_dataquality_kp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,326 @@
"""seperate file for tests of dataquality_kp"""
import aiohttp
import pytest

from app.i18n import active_translation
from app.knowledge_panels import KnowledgePanels

from .test_utils import mock_async_get_factory, tidy_html


@pytest.fixture(autouse=True)
def auto_activate_lang():
"""auto activate translations for each function"""
with active_translation():
yield


async def test_data_quality_kp_with_country(monkeypatch):
"""test_data_quality_kp_with_country"""
expected_url = "https://tr-en.openfoodfacts.org/data-quality-errors.json"
base_url = "https://tr-en.openfoodfacts.org/data-quality-errors"
json_content = {
"count": 129,
"tags": [
{
"id": "en:ecoscore-production-system-no-label",
"known": 0,
"name": "ecoscore-production-system-no-label",
"products": 1848,
"url": f"{base_url}/ecoscore-production-system-no-label",
},
{
"id": "en:no-packaging-data",
"known": 0,
"name": "no-packaging-data",
"products": 1788,
"url": f"{base_url}/no-packaging-data",
},
{
"id": "en:ecoscore-origins-of-ingredients-origins-are-100-percent-unknown",
"known": 0,
"name": "ecoscore-origins-of-ingredients-origins-are-100-percent-unknown",
"products": 1778,
"url": (
f"{base_url}/" "ecoscore-origins-of-ingredients-origins-are-100-percent-unknown"
),
},
],
}

monkeypatch.setattr(
aiohttp.ClientSession,
"get",
mock_async_get_factory(expected_url, json_content=json_content),
)
result = await KnowledgePanels(
facet="country", value="Turkey", country="Hungary"
).data_quality_kp()
first_element = result["Quality"]["elements"][0]
first_element["text_element"]["html"] = tidy_html(first_element["text_element"]["html"])
expected_text = """
<ul>
<p>The total number of issues are <b>129</b></p>
<li>
<a href="https://tr-en.openfoodfacts.org/data-quality-errors/ecoscore-production-system-no-label">1848 products with ecoscore-production-system-no-label</a>
</li>
<li>
<a href="https://tr-en.openfoodfacts.org/data-quality-errors/no-packaging-data">1788 products with no-packaging-data</a>
</li>
<li>
<a href="https://tr-en.openfoodfacts.org/data-quality-errors/ecoscore-origins-of-ingredients-origins-are-100-percent-unknown">1778 products with ecoscore-origins-of-ingredients-origins-are-100-percent-unknown</a>
</li>
</ul>
""" # noqa: E501 # allow long lines
# assert html separately to have better output in case of error
assert first_element["text_element"]["html"] == tidy_html(expected_text)
# now replace it for concision of output
first_element["text_element"]["html"] = "ok"
assert result == {
"Quality": {
"elements": [
{
"element_type": "text",
"text_element": {
"html": "ok",
"source_text": "Data-quality issues",
"source_url": "https://tr-en.openfoodfacts.org/data-quality-errors",
},
}
],
"title_element": {"title": "Data-quality issues related to Turkey "},
}
}


async def test_data_quality_kp_with_one_facet_and_value(monkeypatch):
"""test_data_quality_kp_with_one_facet_and_value"""
expected_url = "https://world.openfoodfacts.org/brand/lidl/data-quality-errors.json"
base_url = "https://world.openfoodfacts.org/brand/lidl/data-quality-errors"
json_content = {
"count": 181,
"tags": [
{
"id": "en:ecoscore-origins-of-ingredients-origins-are-100-percent-unknown",
"known": 0,
"name": "ecoscore-origins-of-ingredients-origins-are-100-percent-unknown",
"products": 7898,
"url": (
f"{base_url}/" "ecoscore-origins-of-ingredients-origins-are-100-percent-unknown"
),
},
{
"id": "en:ecoscore-production-system-no-label",
"known": 0,
"name": "ecoscore-production-system-no-label",
"products": 7883,
"url": f"{base_url}/ecoscore-production-system-no-label",
},
{
"id": "en:no-packaging-data",
"known": 0,
"name": "no-packaging-data",
"products": 6406,
"url": f"{base_url}/no-packaging-data",
},
],
}

monkeypatch.setattr(
aiohttp.ClientSession,
"get",
mock_async_get_factory(expected_url, json_content=json_content),
)
result = await KnowledgePanels(facet="brand", value="lidl").data_quality_kp()
first_element = result["Quality"]["elements"][0]
first_element["text_element"]["html"] = tidy_html(first_element["text_element"]["html"])
expected_text = """
<ul>
<p>The total number of issues are <b>181</b></p>
<li>
<a href="https://world.openfoodfacts.org/brand/lidl/data-quality-errors/ecoscore-origins-of-ingredients-origins-are-100-percent-unknown">7898 products with ecoscore-origins-of-ingredients-origins-are-100-percent-unknown</a>
</li>
<li>
<a href="https://world.openfoodfacts.org/brand/lidl/data-quality-errors/ecoscore-production-system-no-label">7883 products with ecoscore-production-system-no-label</a>
</li>
<li>
<a href="https://world.openfoodfacts.org/brand/lidl/data-quality-errors/no-packaging-data">6406 products with no-packaging-data</a>
</li>
</ul>
""" # noqa: E501 # allow long lines
# assert html separately to have better output in case of error
assert first_element["text_element"]["html"] == tidy_html(expected_text)
# now replace it for concision of output
first_element["text_element"]["html"] = "ok"
assert result == {
"Quality": {
"elements": [
{
"element_type": "text",
"text_element": {
"html": "ok",
"source_text": "Data-quality issues",
"source_url": "https://world.openfoodfacts.org/brand/lidl/"
+ "data-quality-errors",
},
}
],
"title_element": {"title": "Data-quality issues related to brand lidl"},
}
}


async def test_data_quality_kp_with_one_facet_and_value_plural_facet(monkeypatch):
"""test_data_quality_kp_with_one_facet_and_value_plural_facet"""
expected_url = "https://world.openfoodfacts.org/brand/lidl/data-quality-errors.json"
base_url = "https://world.openfoodfacts.org/brand/lidl/data-quality-errors"
json_content = {
"count": 181,
"tags": [
{
"id": "en:ecoscore-origins-of-ingredients-origins-are-100-percent-unknown",
"known": 0,
"name": "ecoscore-origins-of-ingredients-origins-are-100-percent-unknown",
"products": 7898,
"url": (
f"{base_url}/" "ecoscore-origins-of-ingredients-origins-are-100-percent-unknown"
),
},
{
"id": "en:ecoscore-production-system-no-label",
"known": 0,
"name": "ecoscore-production-system-no-label",
"products": 7883,
"url": f"{base_url}/ecoscore-production-system-no-label",
},
{
"id": "en:no-packaging-data",
"known": 0,
"name": "no-packaging-data",
"products": 6406,
"url": f"{base_url}/no-packaging-data",
},
],
}

monkeypatch.setattr(
aiohttp.ClientSession,
"get",
mock_async_get_factory(expected_url, json_content=json_content),
)
result = await KnowledgePanels(facet="brands", value="lidl").data_quality_kp()
first_element = result["Quality"]["elements"][0]
first_element["text_element"]["html"] = tidy_html(first_element["text_element"]["html"])
expected_text = """
<ul>
<p>The total number of issues are <b>181</b></p>
<li>
<a href="https://world.openfoodfacts.org/brand/lidl/data-quality-errors/ecoscore-origins-of-ingredients-origins-are-100-percent-unknown">7898 products with ecoscore-origins-of-ingredients-origins-are-100-percent-unknown</a>
</li>
<li>
<a href="https://world.openfoodfacts.org/brand/lidl/data-quality-errors/ecoscore-production-system-no-label">7883 products with ecoscore-production-system-no-label</a>
</li>
<li>
<a href="https://world.openfoodfacts.org/brand/lidl/data-quality-errors/no-packaging-data">6406 products with no-packaging-data</a>
</li>
</ul>
""" # noqa: E501 # allow long lines
# assert html separately to have better output in case of error
assert first_element["text_element"]["html"] == tidy_html(expected_text)
# now replace it for concision of output
first_element["text_element"]["html"] = "ok"
assert result == {
"Quality": {
"elements": [
{
"element_type": "text",
"text_element": {
"html": "ok",
"source_text": "Data-quality issues",
"source_url": "https://world.openfoodfacts.org/brand/lidl/"
+ "data-quality-errors",
},
}
],
"title_element": {"title": "Data-quality issues related to brand lidl"},
}
}


async def test_data_quality_kp_with_all_tags(monkeypatch):
"""test_data_quality_kp_with_all_tags"""
expected_url = (
"https://world.openfoodfacts.org/category/beers/brand/budweiser/data-quality-errors.json"
)
json_content = {
"count": 24,
"tags": [
{
"id": "en:alcoholic-beverages-category-without-alcohol-value",
"known": 0,
"name": "alcoholic-beverages-category-without-alcohol-value",
"products": 13,
"url": "https://world.openfoodfacts.org/category/beers/data-quality-errors/alcoholic-beverages-category-without-alcohol-value", # noqa: E501 # allow long lines
},
{
"id": "en:ecoscore-production-system-no-label",
"known": 0,
"name": "ecoscore-production-system-no-label",
"products": 13,
"url": "https://world.openfoodfacts.org/category/beers/data-quality-errors/ecoscore-production-system-no-label", # noqa: E501 # allow long lines
},
{
"id": "en:ecoscore-origins-of-ingredients-origins-are-100-percent-unknown",
"known": 0,
"name": "ecoscore-origins-of-ingredients-origins-are-100-percent-unknown",
"products": 12,
"url": "https://world.openfoodfacts.org/category/beers/data-quality-errors/ecoscore-origins-of-ingredients-origins-are-100-percent-unknown", # noqa: E501 # allow long lines
},
],
}

monkeypatch.setattr(
aiohttp.ClientSession,
"get",
mock_async_get_factory(expected_url, json_content=json_content),
)
result = await KnowledgePanels(
facet="category", value="beers", sec_facet="brand", sec_value="budweiser"
).data_quality_kp()
first_element = result["Quality"]["elements"][0]
first_element["text_element"]["html"] = tidy_html(first_element["text_element"]["html"])
expected_text = """
<ul>
<p>The total number of issues are <b>24</b></p>
<li>
<a href="https://world.openfoodfacts.org/category/beers/data-quality-errors/alcoholic-beverages-category-without-alcohol-value">13 products with alcoholic-beverages-category-without-alcohol-value</a>
</li>
<li>
<a href="https://world.openfoodfacts.org/category/beers/data-quality-errors/ecoscore-production-system-no-label">13 products with ecoscore-production-system-no-label</a>
</li>
<li>
<a href="https://world.openfoodfacts.org/category/beers/data-quality-errors/ecoscore-origins-of-ingredients-origins-are-100-percent-unknown">12 products with ecoscore-origins-of-ingredients-origins-are-100-percent-unknown</a>
</li>
</ul>
""" # noqa: E501 # allow long lines
# assert html separately to have better output in case of error
assert first_element["text_element"]["html"] == tidy_html(expected_text)
# now replace it for concision of output
first_element["text_element"]["html"] = "ok"
assert result == {
"Quality": {
"elements": [
{
"element_type": "text",
"text_element": {
"html": "ok",
"source_text": "Data-quality issues",
"source_url": "https://world.openfoodfacts.org/category/beers/brand/budweiser/data-quality-errors", # noqa: E501
},
}
],
"title_element": {
"title": "Data-quality issues related to category beers brand budweiser"
},
}
}
Loading
Loading