-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 0.3.x dev - Update dependencies and PHP to 8.1 #47
Conversation
…-dev # Conflicts: # .github/workflows/ci.yml # composer.json # phpstan.neon.dist # src/Api.php # src/Collection.php # src/Document.php
Can we merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good to me, but I noticed tests failed due to a (seemingly unrelated?) problem with calls made out to https://world.openfoodfacts.net/cgi/product_jqm2.pl : "Server error: POST https://world.openfoodfacts.net/cgi/product_jqm2.pl
resulted in a 502 Bad Gateway
response".
Happens at calling
Line 472 in ef4eb31
$response = $this->httpClient->request('post', $url, $data); |
- OpenFoodFactsTests\ApiFoodCacheTest::testApiAddProduct
- OpenFoodFactsTests\ApiFoodTest::testApiAddProduct
What's the status here? I've just run all the tests and they pass so the error might have been just a temporary api issue not related to this repository. And as a side note it's blocking a related package openfoodfacts/openfoodfacts-laravel#43 from being updated to the recent Laravel, |
This needs to be merged. It's creating a bottleneck for the related packages. |
I launched the phpunit on my side, except this error : #47 (comment) all it's works In this project, it's real difficult to update the code... |
@epalmans you need to reapprove since you requested changes |
done.
After your review we may merge and tag it |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you all for getting this one through 🎉
What
Screenshot
Fixes
#45