Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 0.3.x dev - Update dependencies and PHP to 8.1 #47

Merged
merged 58 commits into from
May 1, 2024
Merged

Conversation

Dwarfex
Copy link
Member

@Dwarfex Dwarfex commented Feb 16, 2023

What

  • Update dependencies
  • Update PHP to 8.1

Screenshot

Fixes

#45

@Dwarfex Dwarfex changed the title 0.3.x dev feat: 0.3.x dev - Update dependencies and PHP to 8.1 Feb 16, 2023
@epalmans epalmans marked this pull request as ready for review February 27, 2023 07:44
@epalmans epalmans requested a review from a team as a code owner February 27, 2023 07:44
@teolemon
Copy link
Member

Can we merge?

Copy link
Member

@epalmans epalmans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good to me, but I noticed tests failed due to a (seemingly unrelated?) problem with calls made out to https://world.openfoodfacts.net/cgi/product_jqm2.pl : "Server error: POST https://world.openfoodfacts.net/cgi/product_jqm2.pl resulted in a 502 Bad Gateway response".

Happens at calling

$response = $this->httpClient->request('post', $url, $data);
from:

  • OpenFoodFactsTests\ApiFoodCacheTest::testApiAddProduct
  • OpenFoodFactsTests\ApiFoodTest::testApiAddProduct

@scybulski
Copy link

What's the status here? I've just run all the tests and they pass so the error might have been just a temporary api issue not related to this repository. And as a side note it's blocking a related package openfoodfacts/openfoodfacts-laravel#43 from being updated to the recent Laravel,

@DonatasIk
Copy link

This needs to be merged. It's creating a bottleneck for the related packages.

src/Collection.php Outdated Show resolved Hide resolved
@Benoit382
Copy link
Collaborator

Benoit382 commented Apr 29, 2024

I launched the phpunit on my side, except this error : #47 (comment) all it's works


In this project, it's real difficult to update the code...

@teolemon teolemon requested review from epalmans and teolemon May 1, 2024 07:18
@teolemon
Copy link
Member

teolemon commented May 1, 2024

@epalmans you need to reapprove since you requested changes

@epalmans
Copy link
Member

epalmans commented May 1, 2024

@epalmans you need to reapprove since you requested changes

done.
Changed:

  • suggested change from @Benoit382
  • marked for skipping: the test that was failing due to api issues
  • satisified cs-fixer/phpstan

After your review we may merge and tag it

Copy link

sonarcloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you all for getting this one through 🎉

@teolemon teolemon added dependencies Pull requests that update a dependency file PHP 8.1 labels May 1, 2024
@epalmans epalmans merged commit 6c6702d into develop May 1, 2024
8 checks passed
@epalmans epalmans deleted the 0.3.x-dev branch May 1, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file PHP 8.1
Projects
Development

Successfully merging this pull request may close these issues.

6 participants