Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add in-context translation (solves #1738) #2421

Closed
wants to merge 2 commits into from

Conversation

teolemon
Copy link
Member

@teolemon teolemon commented Oct 12, 2019

@hangy
Copy link
Member

hangy commented Oct 13, 2019

I tried adding the JavaScript with Chrome DevTools, but even after logging in, it doesn't display any translations for me. image I suppose there would need some way to let Crowdin know which text is which, as the internal ID is different from the displayed text (which is why we have a custom version of gettext). Also, we shouldn't always include that script, since it immediately forces the Crowdin login dialog on the user:
image

Copy link
Member

@hangy hangy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teolemon
Copy link
Member Author

My understanding is that they have this pseudo language called lolcat. So the user would need to switch the website to lolcat, and then indicate the language.
Something like
fr-lolcat.openfoodfacts.org would possibly work.
translate-fr or fr-translate would be more intuitive

@teolemon
Copy link
Member Author

@teolemon teolemon changed the title Add Crowdin in context translation [WIP] Add in-context translation Jan 10, 2020
@teolemon teolemon added the 🌐 i18n Regarding software localization label Jan 10, 2020
@teolemon teolemon changed the title [WIP] Add in-context translation [WIP] Add in-context translation (solves #1738) Jan 10, 2020
@teolemon teolemon marked this pull request as draft April 9, 2020 18:49
@teolemon teolemon marked this pull request as ready for review April 9, 2020 18:49
@teolemon teolemon marked this pull request as draft April 9, 2020 18:49
@sonarcloud
Copy link

sonarcloud bot commented Jan 29, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@teolemon teolemon changed the title [WIP] Add in-context translation (solves #1738) feat: Add in-context translation (solves #1738) Feb 27, 2022
@teolemon teolemon self-assigned this Apr 28, 2022
@teolemon teolemon closed this Mar 17, 2023
@teolemon teolemon deleted the teolemon-patch-4 branch March 17, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 i18n Regarding software localization
Projects
Development

Successfully merging this pull request may close these issues.

2 participants