feat: robotoff anonymous questions #7379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgarel
force-pushed
the
feat-robotoff-anonymous-questions
branch
from
b48741b
to
d3e8d01
Compare
github-actions
bot
added
🐋 Docker
alexgarel
commented
Sep 21, 2022
| @@ -47,7 +47,7 @@ | |||
| <p>→ <a href="[% public_product_url %]">[% lang("product_page_on_the_public_database") %]</a></p> | |||
| [% END %] | |||
|
|
|||
| [% IF (user_id.defined) && (robotoff_url.defined) && (robotoff_url.length > 0) %] | |||
| [% IF (robotoff_url.defined) && (robotoff_url.length > 0) %] | |||
There was a problem hiding this comment.
yes it's that easy, because robotoff takes care of computing device_id using url.
There was a problem hiding this comment.
so for a non logged in OFF website user, how is the device_id computed? is it a hash of the user ip address or something?
There was a problem hiding this comment.
yes it's the sha1 of user ip, see https://github.com/openfoodfacts/robotoff/blob/e46942f0055b54183ef5570b7c39215ed312309c/robotoff/app/api.py#L235
raphael0202
reviewed
Sep 22, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
raphael0202
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
feat: Make it possible for anonymous users to see and answer robotoff questions
build: some changes to be compatible with a local robotoff instance
fixes: