feat: Allowing Users to subscribe to the pro-newsletter

[MonalikaPatnaik]

What

tried writing functions in Brevo.pm module for adding users to contact list and getting their contact info.

Screenshot

Related issue(s) and discussion

• Fixes Make it possible to subscribe to the pro newsletter #8505

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[codecov-commenter]

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (e8cb4f4) 49.28% compared to head (cb1442e) 44.01%.

Files	Patch %	Lines
lib/ProductOpener/Brevo.pm	56.25%	12 Missing and 2 partials ⚠️
lib/ProductOpener/Users.pm	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8856      +/-   ##
==========================================
- Coverage   49.28%   44.01%   -5.27%     
==========================================
  Files          66       65       -1     
  Lines       20546    20493      -53     
  Branches     4946     4940       -6     
==========================================
- Hits        10126     9021    -1105     
- Misses       9132    10299    +1167     
+ Partials     1288     1173     -115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[alexgarel]

Thanks, It's almost good, some changes proposed though to avoid slowing down dev environment and tests.

[alexgarel]

Nearly good, I added comments, I hope they are not too cryptic. Otherwise I can try to fix it for you.

[MonalikaPatnaik]

@alexgarel could you pls tell how would I mock $ProductOpener::Brevo::brevo_api_key in my test, I have tried but it is using the actual value defined in the Brevo.pm module only :"

[alexgarel]

@MonalikaPatnaik this was not possible to change the brevo_api_key in the module because it was a private variable. So I changed a bit the pattern to use a function so that we can mock it.

At the end I refactored the test a bit to make it less repetitive and easier to read.

Thanks for this PR !

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[MonalikaPatnaik]

@MonalikaPatnaik this was not possible to change the brevo_api_key in the module because it was a private variable. So I changed a bit the pattern to use a function so that we can mock it.

At the end I refactored the test a bit to make it less repetitive and easier to read.

Thanks for this PR !

Thankyou so much @alexgarel🙂

[teolemon]

Just to be clear @MonalikaPatnaik , there's no UI yet, right ?

[MonalikaPatnaik]

Just to be clear @MonalikaPatnaik , there's no UI yet, right ?

No @teolemon, it's a functionality only