-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taxonomy: correction sweet spreads #9709
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9709 +/- ##
=======================================
Coverage 49.45% 49.45%
=======================================
Files 67 67
Lines 20645 20645
Branches 4978 4978
=======================================
Hits 10209 10209
Misses 9139 9139
Partials 1297 1297 ☔ View full report in Codecov by Sentry. |
<en:Jams | ||
en:ginger jams | ||
fr:Confitures de gingembre | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to keep separated "jams" vs "preserves" for ginger?
The reason is that ginger jams in EU should have 150g of fruit per 1000g. Which is not the case for preserves. (see: https://github.com/openfoodfacts/openfoodfacts-server/pull/9707/files and https://eur-lex.europa.eu/legal-content/EN/TXT/?uri=CELEX%3A02001L0113-20131118)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, didn't see that sorry. Should then put ginger jams under ginger preserves?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that should be fine like this.
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super. Thanks @moon-rabbitOFF for the correction.
* Update categories.txt * Update categories.txt * Update categories.txt
What
Screenshot
Related issue(s) and discussion