Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: correction sweet spreads #9709

Merged
merged 3 commits into from
Jan 28, 2024
Merged

Conversation

moon-rabbitOFF
Copy link
Contributor

What

Screenshot

Related issue(s) and discussion

  • Fixes #[ISSUE NUMBER]

@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies categories labels Jan 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b1923fb) 49.45% compared to head (640147a) 49.45%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9709   +/-   ##
=======================================
  Coverage   49.45%   49.45%           
=======================================
  Files          67       67           
  Lines       20645    20645           
  Branches     4978     4978           
=======================================
  Hits        10209    10209           
  Misses       9139     9139           
  Partials     1297     1297           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines -93465 to -93468
<en:Jams
en:ginger jams
fr:Confitures de gingembre

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to keep separated "jams" vs "preserves" for ginger?

The reason is that ginger jams in EU should have 150g of fruit per 1000g. Which is not the case for preserves. (see: https://github.com/openfoodfacts/openfoodfacts-server/pull/9707/files and https://eur-lex.europa.eu/legal-content/EN/TXT/?uri=CELEX%3A02001L0113-20131118)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, didn't see that sorry. Should then put ginger jams under ginger preserves?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that should be fine like this.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@benbenben2 benbenben2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super. Thanks @moon-rabbitOFF for the correction.

@benbenben2 benbenben2 merged commit 8b70598 into main Jan 28, 2024
12 checks passed
@benbenben2 benbenben2 deleted the correction-sweet-spreads branch January 28, 2024 21:32
john-gom pushed a commit that referenced this pull request May 24, 2024
* Update categories.txt

* Update categories.txt

* Update categories.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
categories 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants