Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: misc fixes #9790

Merged
merged 6 commits into from
Mar 18, 2024
Merged

taxonomy: misc fixes #9790

merged 6 commits into from
Mar 18, 2024

Conversation

teolemon
Copy link
Member

What

taxonomy: misc fixes

@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧽 Data quality https://wiki.openfoodfacts.org/Quality Ingredients processing 🥗 Ingredients labels Feb 12, 2024
taxonomies/data_quality.txt Outdated Show resolved Hide resolved
taxonomies/data_quality.txt Outdated Show resolved Hide resolved
taxonomies/data_quality.txt Outdated Show resolved Hide resolved
taxonomies/data_quality.txt Outdated Show resolved Hide resolved
Comment on lines 42997 to 43009
bg:сироп от бъз
<<<<<<< Updated upstream
da:hyldbærsirup
de:Holunderbeersirup
es:jarabe de sauco
fi:seljamarjasiirappi
=======
da:hyldebærsirup
de:Holunderbeersirup
es:jarabe de sauco
fi:seljanmarjasiirappi
>>>>>>> Stashed changes
fr:sirop de sureau
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bg:сироп от бъз
<<<<<<< Updated upstream
da:hyldbærsirup
de:Holunderbeersirup
es:jarabe de sauco
fi:seljamarjasiirappi
=======
da:hyldebærsirup
de:Holunderbeersirup
es:jarabe de sauco
fi:seljanmarjasiirappi
>>>>>>> Stashed changes
fr:sirop de sureau
bg:сироп от бъз
da:hyldbærsirup
de:Holunderbeersirup
es:jarabe de sauco
fi:seljamarjasiirappi
fr:sirop de sureau

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@@ -15,6 +15,8 @@ synonyms:en:hydrolysed, hydrolyzed

synonyms:en:pasteurised, pasteurized

synonyms:fr:de production biologique, issu de l'agriculture biologique,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have examples?

Remember that synonyms in the taxonomies are for words that are part of the ingredient (not the whole ingredient)

Copy link
Collaborator

@benbenben2 benbenben2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

See 2 comments

@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Mar 7, 2024
@teolemon teolemon force-pushed the various-fixes-12-feb-2024 branch from 984cd6d to 41191dc Compare March 18, 2024 08:24
@teolemon teolemon enabled auto-merge (squash) March 18, 2024 08:25
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@teolemon teolemon merged commit 3a85798 into main Mar 18, 2024
12 checks passed
@teolemon teolemon deleted the various-fixes-12-feb-2024 branch March 18, 2024 09:03
john-gom pushed a commit that referenced this pull request May 24, 2024
* Add more processing translations

* add data quality translations

* add ingredients translations

* Apply suggestions from code review

* Update ingredients.txt

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧽 Data quality https://wiki.openfoodfacts.org/Quality Ingredients processing 💥 Merge Conflicts 💥 Merge Conflicts 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants