Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product carousel improvements #1139

Closed
3 tasks done
M123-dev opened this issue Feb 13, 2022 · 2 comments
Closed
3 tasks done

Product carousel improvements #1139

M123-dev opened this issue Feb 13, 2022 · 2 comments
Assignees
@cli1005
Labels
product scan carousel 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…

Comments

@M123-dev
Copy link
Member

M123-dev commented Feb 13, 2022 •
edited by cli1005
Loading

What

  • Scanning a product should scroll to the scanned product
  • Strange spinning/reordering effect when opening a product page
  • The carousel should not reorder at all
@M123-dev M123-dev added the 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… label Feb 13, 2022
@teolemon teolemon changed the title Product carousel improvments Product carousel improvements Mar 6, 2022
@cli1005
Copy link
Contributor

cli1005 commented Apr 4, 2022

I met the same issue when working on #1034 , apart of the reordering issue, the carousel switches to the last scanned product when returning from product page and ranking page.

@cli1005 cli1005 self-assigned this Apr 6, 2022
@M123-dev M123-dev mentioned this issue Apr 6, 2022
Merged
cli1005 added a commit to cli1005/smooth-app that referenced this issue Apr 21, 2022
@cli1005
fix: openfoodfacts#1139 - carousel spinning issues
167c7b9
@cli1005
Copy link
Contributor

cli1005 commented Apr 21, 2022

BEFORE

  • Strange spinning / reordering effect when returning from product page or ranking page (turn to the last card every time)
  • Nothing happens when scanning a product which is already listed in carousel

AFTER

  • Show the last consulted carousel card when returning from product page or ranking page
  • Switch to the product card when scanning a barcode which is already listed in carousel
rpreplay-final1650469846_CsmeQg9L.mp4

cli1005 added a commit to cli1005/smooth-app that referenced this issue Apr 21, 2022
@cli1005
fix: openfoodfacts#1139 - setter updated
ea95dff
@cli1005 cli1005 mentioned this issue Apr 21, 2022
Merged
cli1005 added a commit to cli1005/smooth-app that referenced this issue Apr 21, 2022
@cli1005
fix: openfoodfacts#1139 - codereview refactoring
1c1037f
@teolemon teolemon linked a pull request Apr 22, 2022 that will close this issue
fix: #1139 - carousel spinning issues #1604
Merged
@teolemon teolemon removed a link to a pull request Apr 22, 2022
fix: #1139 - carousel spinning issues #1604
Merged
cli1005 added a commit to cli1005/smooth-app that referenced this issue Apr 25, 2022
@cli1005
fix: openfoodfacts#1139 - carousel spinning issues refactoring
99e4b79
@github-actions github-actions bot mentioned this issue Apr 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cli1005 cli1005

Labels
product scan carousel 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@teolemon @M123-dev @cli1005