-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #1139 - carousel spinning issues #1604
fix: #1139 - carousel spinning issues #1604
Conversation
@cli1005 For the record I receive an email every time you decide to close or open a PR. That mean this morning at least 6 emails received just because of you. In that particular case maybe you can create PRs as draft, fine-tune what is needed, and then only when you're done remove the draft mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cli1005! I don't know if it works but it looks rather OK.
Please have a look at my comments though.
👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small comment, but the rest looks good, thanks @cli1005
Codecov Report
@@ Coverage Diff @@
## develop #1604 +/- ##
==========================================
- Coverage 8.86% 8.61% -0.25%
==========================================
Files 161 164 +3
Lines 6623 6870 +247
==========================================
+ Hits 587 592 +5
- Misses 6036 6278 +242
Continue to review full report at Codecov.
|
What
Fix of strange spinning/reordering effect when opening a product page
more details : #1139 (comment)
Screenshot
rpreplay-final1650469846_CsmeQg9L.mp4
Fixes bug(s)