Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #3536 don't force entry into edit screen on card tap #3540

Conversation

AshAman999
Copy link
Member

Screenshot

Changes

  • Removed the extra inkwell and associated variables used
demo.2.mp4

Fixes bug(s)

#3536

@AshAman999 AshAman999 requested a review from a team as a code owner January 6, 2023 13:41
Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @AshAman999!

@codecov-commenter
Copy link

Codecov Report

Merging #3540 (8665a8c) into develop (62f7769) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #3540   +/-   ##
========================================
  Coverage    11.07%   11.08%           
========================================
  Files          262      262           
  Lines        12955    12945   -10     
========================================
  Hits          1435     1435           
+ Misses       11520    11510   -10     
Impacted Files Coverage Δ
...ooth_app/lib/background/background_task_image.dart 0.00% <0.00%> (ø)
...pp/lib/cards/product_cards/product_title_card.dart 0.00% <0.00%> (ø)
...ckages/smooth_app/lib/database/transient_file.dart 0.00% <0.00%> (ø)
...s/smooth_app/lib/tmp_crop_image/new_crop_page.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AshAman999 AshAman999 merged commit f39de2a into openfoodfacts:develop Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants