Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: New Crowdin translations to review and merge #4295

Closed
wants to merge 643 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

What

Checklist

  • Check that they are no bad translations. If there are, correct them directly in Crowdin so that they are not resynced again. Then you can correct them here as well, or wait 24 hours for the sync to happen automatically.
  • Put extra attention on Acholi, which is used mistakenly as a sandbox by people discovering the self-service translation button on Open Food Facts
  • Once you are happy, that automated checks pass, you can approve the PR and merge it.

Part of

  • Translations

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

Merging #4295 (13ad444) into develop (480938e) will decrease coverage by 0.17%.
Report is 24 commits behind head on develop.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4295      +/-   ##
===========================================
- Coverage    10.31%   10.14%   -0.17%     
===========================================
  Files          293      295       +2     
  Lines        14704    15088     +384     
===========================================
+ Hits          1517     1531      +14     
- Misses       13187    13557     +370     

see 45 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor Author

github-actions bot commented Jul 24, 2023

You can test this PR on: Android

@github-actions github-actions bot added the 🍎 iOS iOS specific issues or PRs label Jul 25, 2023
@@ -0,0 +1 @@
NSCameraUsageDescription = "This app needs camera access to scan barcodes and to take product photos";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@g123k @monsieurtanuki @M123-dev is this file used ? My new setup of crowdin has synced it for some reason. Do you notice anything weird in the English files of this PR ? Strings you have removed, or strings you have added but were never synced ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I remember this file is used for the permission messages on iOS only.
I think one file is for the default message, and I can't remember if there is one file for all translations or one file per language.
Don't know if it was helpful.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crowdin seems to be creating duplicates of the file
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file should go in packages/smooth_app/ios/Runner

@teolemon teolemon closed this Jul 31, 2023
@teolemon teolemon deleted the l10n_develop branch July 31, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍎 iOS iOS specific issues or PRs translations
Development

Successfully merging this pull request may close these issues.

4 participants