-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: New Crowdin translations to review and merge #4295
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4295 +/- ##
===========================================
- Coverage 10.31% 10.14% -0.17%
===========================================
Files 293 295 +2
Lines 14704 15088 +384
===========================================
+ Hits 1517 1531 +14
- Misses 13187 13557 +370 see 45 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
2dca6bb
to
13bef18
Compare
5161332
to
3371d7f
Compare
3371d7f
to
551fd82
Compare
551fd82
to
88d7ea7
Compare
You can test this PR on: Android |
248706b
to
77ace4f
Compare
@@ -0,0 +1 @@ | |||
NSCameraUsageDescription = "This app needs camera access to scan barcodes and to take product photos"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@g123k @monsieurtanuki @M123-dev is this file used ? My new setup of crowdin has synced it for some reason. Do you notice anything weird in the English files of this PR ? Strings you have removed, or strings you have added but were never synced ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I remember this file is used for the permission messages on iOS only.
I think one file is for the default message, and I can't remember if there is one file for all translations or one file per language.
Don't know if it was helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file should go in packages/smooth_app/ios/Runner
What
Checklist
Part of