Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Search page improvements #4338

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 19, 2023

Hi everyone,

Here are the edits this PR provides for the search page:

  • The clear button now has an Inkwell on top of the search bar and not bellow (= invisible)
  • Clear button with a good semantic (previously: "X" was detected)
  • Swipe to dismiss with an icon
  • The pen icon now have a tooltip

A video of the new behavior: Search.webm

- Clear button with a correct Inkwell
- Clear button with a good semantic

Swipe to dismiss with an icon
@g123k g123k self-assigned this Jul 19, 2023
@g123k g123k requested a review from a team as a code owner July 19, 2023 12:37
@github-actions github-actions bot added 🌐 l10n 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… labels Jul 19, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4338 (b9022b6) into develop (5b376d0) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4338      +/-   ##
===========================================
- Coverage    10.54%   10.53%   -0.01%     
===========================================
  Files          290      290              
  Lines        14294    14304      +10     
===========================================
  Hits          1507     1507              
- Misses       12787    12797      +10     
Impacted Files Coverage Δ
...smooth_app/lib/pages/scan/search_history_view.dart 0.00% <0.00%> (ø)
...ackages/smooth_app/lib/pages/scan/search_page.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

@M123-dev M123-dev merged commit 0876d77 into openfoodfacts:develop Jul 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 l10n 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… 🔎 Search
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants