Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Increase padding for attribute groups #4357

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 22, 2023

Hi everyone!

On the product, the list of attribute groups can be improved by increasing simply their paddings.
Actually, we have a Wrap widget, with some spacing between elements.

Instead, we pass this space to the padding.

I have also tweaked a little bit the case, where there is only one attribute, to ensure it will fit all the width.

A video with multiple attributes: Multiple.webm
And a single one: Single.webm

@g123k g123k requested a review from a team as a code owner July 22, 2023 07:50
@g123k g123k self-assigned this Jul 22, 2023
@g123k g123k changed the title feat; Increase padding for attribute groups feat: Increase padding for attribute groups Jul 22, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4357 (a735149) into develop (580b822) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4357      +/-   ##
===========================================
- Coverage    10.45%   10.45%   -0.01%     
===========================================
  Files          291      291              
  Lines        14409    14413       +4     
===========================================
  Hits          1507     1507              
- Misses       12902    12906       +4     
Impacted Files Coverage Δ
...app/lib/pages/product/summary_attribute_group.dart 0.00% <0.00%> (ø)
...ges/smooth_app/lib/pages/product/summary_card.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

@teolemon teolemon merged commit 7fe073e into openfoodfacts:develop Aug 3, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants