Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ensure Country / Language / Nutrient picker look the same #4389

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 28, 2023

Hi everyone,

Following the improvements on the country picker (title, list with separators, highlighting search…), here are the same treatment for the language picker and nutrition picker:

Screenshot 2023-07-28 at 11 23 12 Screenshot 2023-07-28 at 11 23 14 Screenshot 2023-07-28 at 11 23 20 Screenshot 2023-07-28 at 11 33 41

@g123k g123k self-assigned this Jul 28, 2023
@g123k g123k requested a review from a team as a code owner July 28, 2023 09:43
@github-actions github-actions bot added 🥫 Product page 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🌐 l10n and removed ⚙️ Settings ✏️ Editing - Nutrition input labels Jul 28, 2023
@g123k g123k linked an issue Jul 28, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

You can test this PR on: Android

@codecov-commenter
Copy link

Codecov Report

Merging #4389 (d5176c6) into develop (f9b7b9d) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4389      +/-   ##
===========================================
- Coverage    10.29%   10.28%   -0.01%     
===========================================
  Files          293      293              
  Lines        14752    14762      +10     
===========================================
  Hits          1519     1519              
- Misses       13233    13243      +10     
Files Changed Coverage Δ
...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart 65.34% <0.00%> (-10.32%) ⬇️
...app/lib/generic_lib/widgets/language_selector.dart 0.00% <0.00%> (ø)
...oth_app/lib/pages/onboarding/country_selector.dart 0.82% <0.00%> (+0.22%) ⬆️
...b/pages/product/nutrition_add_nutrient_button.dart 0.00% <0.00%> (ø)
packages/smooth_app/lib/widgets/smooth_text.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@teolemon teolemon merged commit fe31fd9 into openfoodfacts:develop Jul 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 l10n 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🥫 Product page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language picker: use the same kind of UI as the country picker
3 participants