Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: App review in the "scan card" #4450

Merged
merged 4 commits into from
Aug 5, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Aug 5, 2023

Hi everyone,

We clearly need to improve our ratings in stores. As the release is approaching, this is just a baby step to better ask users to review the app.

A few things:

  • We now count the number of scans (will be useful later)
  • The review thing will have a 1/10 chance to appear after a valid scan
  • I have created a better way to migrate user preferences (previously we only add a boolean to state if it was the first scan)
  • With the "no" answer, we redirect to the form
  • The code to check if the user still use "Smoothie" is removed
  • The layout is tested on small devices

A video: Demo.webm

Some screenshots:
Screenshot_1691227342
Screenshot_1691227352
Screenshot_1691226641

@g123k g123k self-assigned this Aug 5, 2023
@g123k g123k requested a review from a team as a code owner August 5, 2023 09:30
@g123k g123k linked an issue Aug 5, 2023 that may be closed by this pull request
@github-actions github-actions bot added 🥫 Product page Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 📈 Analytics We use Sentry and Matomo, with an opt-in system 👥 User management Account login, signup, signout 🧪 Tests 🌐 l10n summary card 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… 🖼️ Photos - Cropping product scan carousel labels Aug 5, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4450 (3bb4675) into develop (1c3921e) will increase coverage by 0.09%.
The diff coverage is 21.01%.

@@             Coverage Diff             @@
##           develop    #4450      +/-   ##
===========================================
+ Coverage    10.17%   10.26%   +0.09%     
===========================================
  Files          295      296       +1     
  Lines        15087    15148      +61     
===========================================
+ Hits          1535     1555      +20     
- Misses       13552    13593      +41     
Files Changed Coverage Δ
...cards/product_cards/smooth_product_card_found.dart 0.00% <ø> (ø)
...kages/smooth_app/lib/helpers/analytics_helper.dart 6.45% <ø> (ø)
...smooth_app/lib/helpers/haptic_feedback_helper.dart 0.00% <ø> (ø)
...e_panel/knowledge_panels/knowledge_panel_card.dart 0.00% <ø> (ø)
...l/knowledge_panels/knowledge_panel_title_card.dart 0.00% <ø> (ø)
.../lib/knowledge_panel/knowledge_panels_builder.dart 0.00% <ø> (ø)
packages/smooth_app/lib/main.dart 12.90% <ø> (ø)
packages/smooth_app/lib/pages/image_crop_page.dart 0.99% <ø> (ø)
.../smooth_app/lib/pages/navigator/app_navigator.dart 0.00% <ø> (ø)
...p/lib/pages/onboarding/consent_analytics_page.dart 0.00% <ø> (ø)
... and 31 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

You can test this PR on: Android

@teolemon
Copy link
Member

teolemon commented Aug 5, 2023

You don't like (our>>the) app

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small wording comment.

@g123k
Copy link
Collaborator Author

g123k commented Aug 5, 2023

You don't like (our>>the) app

This is intended, but we can't revert if necessary.
The initial call to action is generic (the app), but when the user optsfor a negative feedback, it's a way to minimize their anger et have a better comment, then a generic "it's just shiit. it don't work blabla"

@teolemon
Copy link
Member

teolemon commented Aug 5, 2023

Fair enough, let's see if that pans out

@teolemon teolemon merged commit 78884a6 into openfoodfacts:develop Aug 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 Analytics We use Sentry and Matomo, with an opt-in system appstores 🌐 l10n 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🖼️ Photos - Cropping Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page product scan carousel 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… stores summary card 🧪 Tests 👥 User management Account login, signup, signout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Ask for the user review in the "scan card"
3 participants