Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: When the server is not responding, we ask users to wait #4494

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Aug 9, 2023

Hi everyone,

Due to the temporary slowness of our infrastructure, we should better catch errors from the server, especially during the signup.

Thanks to a change in the Dart package, we can inform the user to wait a little bit.

(Feel free to change the message if necessary)

@g123k g123k added the 👥 User management Account login, signup, signout label Aug 9, 2023
@g123k g123k requested a review from a team as a code owner August 9, 2023 06:58
@g123k g123k self-assigned this Aug 9, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4494 (3edaf93) into develop (de837d3) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4494      +/-   ##
===========================================
- Coverage    10.34%   10.34%   -0.01%     
===========================================
  Files          296      296              
  Lines        15267    15270       +3     
===========================================
  Hits          1579     1579              
- Misses       13688    13691       +3     
Files Changed Coverage Δ
...th_app/lib/pages/user_management/sign_up_page.dart 49.15% <0.00%> (-0.64%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@g123k
Copy link
Collaborator Author

g123k commented Aug 9, 2023

Why not mobile_scanner 3.4.1 ? https://github.com/juliansteenbakker/mobile_scanner/releases

Mmm... Not sure to understand the link with this issue

@teolemon
Copy link
Member

teolemon commented Aug 9, 2023

You bump it in the pubspec.yaml. Merging anyway

@teolemon teolemon merged commit aa8fbb4 into openfoodfacts:develop Aug 9, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants