Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: When the server is not responding, we ask users to wait #4494

Merged
merged 1 commit into from
Aug 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/smooth_app/lib/l10n/app_en.arb
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@
"sign_up_page_user_name_already_used": "The user name already exists, please choose another username.",
"sign_up_page_email_already_exists": "already exists, login to the account or try with another email.",
"sign_up_page_provide_valid_email": "Please provide a valid email address.",
"sign_up_page_server_busy": "We are deeply sorry, we have some technical difficulties to create your account. Please try again later.",
"@Settings": {},
"settingsTitle": "Settings",
"@settingsTitle": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,9 @@ class _SignUpPageState extends State<SignUpPage> with TraceableClientMixin {
.contains(SignUpStatusError.USERNAME_ALREADY_USED)) {
_userFocusNode.requestFocus();
errorMessage = appLocalisations.sign_up_page_user_name_already_used;
} else if (status.statusErrors!
.contains(SignUpStatusError.SERVER_BUSY)) {
errorMessage = appLocalisations.sign_up_page_server_busy;
} else {
errorMessage = status.error;
}
Expand Down
27 changes: 13 additions & 14 deletions packages/smooth_app/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -598,10 +598,10 @@ packages:
dependency: "direct main"
description:
name: flutter_secure_storage
sha256: "5abe3d5c25ab435e48c47fb61bac25606062a305fac637c2f020e25abd30014a"
sha256: "98352186ee7ad3639ccc77ad7924b773ff6883076ab952437d20f18a61f0a7c5"
url: "https://pub.dev"
source: hosted
version: "5.1.2"
version: "8.0.0"
flutter_secure_storage_linux:
dependency: transitive
description:
Expand All @@ -614,10 +614,10 @@ packages:
dependency: transitive
description:
name: flutter_secure_storage_macos
sha256: "388f76fd0f093e7415a39ec4c169ae7cceeee6d9f9ba529d788a13f2be4de7bd"
sha256: "083add01847fc1c80a07a08e1ed6927e9acd9618a35e330239d4422cd2a58c50"
url: "https://pub.dev"
source: hosted
version: "1.1.2"
version: "3.0.0"
flutter_secure_storage_platform_interface:
dependency: transitive
description:
Expand All @@ -638,10 +638,10 @@ packages:
dependency: transitive
description:
name: flutter_secure_storage_windows
sha256: ca89c8059cf439985aa83c59619b3674c7ef6cc2e86943d169a7369d6a69cab5
sha256: fc2910ec9b28d60598216c29ea763b3a96c401f0ce1d13cdf69ccb0e5c93c3ee
url: "https://pub.dev"
source: hosted
version: "1.1.3"
version: "2.0.0"
flutter_svg:
dependency: "direct main"
description:
Expand Down Expand Up @@ -985,12 +985,11 @@ packages:
mobile_scanner:
dependency: transitive
description:
path: "."
ref: "5aa2c11915467b19dfc5fd3a9e59641d2958ffeb"
resolved-ref: "5aa2c11915467b19dfc5fd3a9e59641d2958ffeb"
url: "https://github.com/openfoodfacts/mobile_scanner.git"
source: git
version: "3.2.1"
name: mobile_scanner
sha256: "9b3d6fb0407f749eb157432b049924277b43ff6948546eeff76260593ad6eca9"
url: "https://pub.dev"
source: hosted
version: "3.4.0"
mockito:
dependency: "direct dev"
description:
Expand All @@ -1011,10 +1010,10 @@ packages:
dependency: "direct main"
description:
name: openfoodfacts
sha256: "86ef1dc9a3cbb464cb020d6bdd87e52c9115df26cc04ac6144eb80d79a0972e2"
sha256: "4c3e095a20bca11006c957ec37d83fda1178dc03bde0254d4cc29d0eb09ebb3b"
url: "https://pub.dev"
source: hosted
version: "2.7.4"
version: "2.8.0"
openfoodfacts_flutter_lints:
dependency: "direct dev"
description:
Expand Down
2 changes: 1 addition & 1 deletion packages/smooth_app/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ dependencies:



openfoodfacts: 2.7.4
openfoodfacts: 2.8.0
# openfoodfacts:
# path: ../../../openfoodfacts-dart

Expand Down