-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Deeplinking for the forgot password page #5362
base: develop
Are you sure you want to change the base?
feat: Deeplinking for the forgot password page #5362
Conversation
You have a formatting issue on your code: https://github.com/openfoodfacts/smooth-app/actions/runs/9489564735/job/26151127165?pr=5362 Running |
Sorry, I missed this. I will fix this |
It seems your commit partially fixes the issue. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5362 +/- ##
==========================================
- Coverage 9.54% 7.00% -2.54%
==========================================
Files 325 397 +72
Lines 16411 21043 +4632
==========================================
- Hits 1567 1475 -92
- Misses 14844 19568 +4724 ☔ View full report in Codecov by Sentry. |
Thanks for the fix. |
Let me check |
[ Screen.Recording.2024-07-06.at.1.39.36.PM.mov](url) It goes back to the home page |
@@ -282,6 +287,8 @@ class _SmoothGoRouter { | |||
} | |||
} else if (path == _ExternalRoutes.MOBILE_APP_DOWNLOAD) { | |||
return AppRoutes.HOME; | |||
} else if (path == _ExternalRoutes.FORGOT_PASSWORD) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move this statement before or after SIGNUP
?
It will allow the regrouping of user management routes.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay will do
Heyy, there are some conflicts, but they seem to be just a few lines. |
What
Added deep linking for the forgot password page.
can be tested at https://world.openfoodfacts.org/forgot-password/
Screenshot
Screen.Recording.2024-06-12.at.4.41.26.PM.mov
Fixes bug(s)
Part of