Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Deeplinking for the forgot password page #5362

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

feat: Deeplinking for the forgot password page #5362

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
09a48cd
feat: added deeplinking to forgot password page
jnnabugwu Jun 6, 2024
89737bf
Merge branch 'deeplinking-forgot-password' of https://github.com/jnna…
jnnabugwu Jun 10, 2024
8f528a3
fix: fix merge conflicts
jnnabugwu Jun 10, 2024
4e1912d
Merge branch 'openfoodfacts:develop' into deeplinking-forgot-password
jnnabugwu Jun 12, 2024
07d5511
fix: formatted app navigator page
jnnabugwu Jul 1, 2024
29973d2
fix: organized imports
jnnabugwu Jul 2, 2024
503eda8
Merge branch 'openfoodfacts:develop' into deeplinking-forgot-password
jnnabugwu Jul 30, 2024
a603218
Merge branch 'develop' into deeplinking-forgot-password
jnnabugwu Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/smooth_app/lib/pages/navigator/app_navigator.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import 'package:smooth_app/pages/product/new_product_page.dart';
import 'package:smooth_app/pages/product/product_loader_page.dart';
import 'package:smooth_app/pages/scan/search_page.dart';
import 'package:smooth_app/pages/scan/search_product_helper.dart';
import 'package:smooth_app/pages/user_management/forgot_password_page.dart';
import 'package:smooth_app/pages/user_management/sign_up_page.dart';
import 'package:smooth_app/query/product_query.dart';

Expand Down Expand Up @@ -223,6 +224,10 @@ class _SmoothGoRouter {
}
},
),
GoRoute(
path: _InternalAppRoutes.FORGOT_PASSWORD_PAGE,
builder: (_, __) => const ForgotPasswordPage(),
),
GoRoute(
path: _InternalAppRoutes.EXTERNAL_PAGE,
builder: (BuildContext context, GoRouterState state) {
Expand Down Expand Up @@ -282,6 +287,8 @@ class _SmoothGoRouter {
}
} else if (path == _ExternalRoutes.MOBILE_APP_DOWNLOAD) {
return AppRoutes.HOME;
} else if (path == _ExternalRoutes.FORGOT_PASSWORD) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this statement before or after SIGNUP?
It will allow the regrouping of user management routes.
Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay will do

return AppRoutes.FORGOT_PASSWORD;
} else if (path == _ExternalRoutes.GUIDE_NUTRISCORE_V2) {
return AppRoutes.GUIDE_NUTRISCORE_V2;
} else if (path == _ExternalRoutes.SIGNUP) {
Expand Down Expand Up @@ -397,6 +404,7 @@ class _InternalAppRoutes {
static const String SEARCH_PAGE = '_search';
static const String EXTERNAL_PAGE = '_external';
static const String SIGNUP_PAGE = '_signup';
static const String FORGOT_PASSWORD_PAGE = '_forgot_password';

static const String _GUIDES = '_guides';
static const String GUIDE_NUTRISCORE_V2_PAGE = '_nutriscore-v2';
Expand All @@ -407,6 +415,7 @@ class _ExternalRoutes {
static const String PRODUCT_EDITION = '/cgi/product.pl';
static const String GUIDE_NUTRISCORE_V2 = '/nutriscore-v2';
static const String SIGNUP = '/signup';
static const String FORGOT_PASSWORD = '/forgot-password';
}

/// A list of internal routes to use with [AppNavigator]
Expand Down Expand Up @@ -452,6 +461,9 @@ class AppRoutes {
'/${_InternalAppRoutes._GUIDES}/${_InternalAppRoutes.GUIDE_NUTRISCORE_V2_PAGE}';

static String get SIGNUP => '/${_InternalAppRoutes.SIGNUP_PAGE}';
static String get FORGOT_PASSWORD =>
'/${_InternalAppRoutes.FORGOT_PASSWORD_PAGE}';

// Open an external link (where path is relative to the OFF website)
static String EXTERNAL(String path) =>
'/${_InternalAppRoutes.EXTERNAL_PAGE}/?path=$path';
Expand Down
Loading