Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new parameters for uploadProof #5480

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Using the latest Prices and off-dart code, we're now able to set location, date and currency for a proof (and not just for each individual price)

Screenshot

From the Prices app, about a proof created from Smoothie with the current PR code:
image
As opposed to a proof without location, date and currency
image

Impacted files

  • background_task_add_prices.dart: 4 new parameters for uploadProof
  • pubspec.lock: wtf
  • pubspec.yaml: upgraded to off-dart 3.12.0

Impacted files:
* `background_task_add_prices.dart`: 4 new parameters for `uploadProof`
* `pubspec.lock`: wtf
* `pubspec.yaml`: upgraded to off-dart 3.12.0
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 7.16%. Comparing base (4d9c7fc) to head (72f3707).
Report is 244 commits behind head on develop.

Files Patch % Lines
..._app/lib/background/background_task_add_price.dart 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5480      +/-   ##
==========================================
- Coverage     9.54%   7.16%   -2.39%     
==========================================
  Files          325     391      +66     
  Lines        16411   20408    +3997     
==========================================
- Hits          1567    1462     -105     
- Misses       14844   18946    +4102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon requested a review from raphael0202 July 5, 2024 15:24
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swell 👍 thanks @monsieurtanuki cc @raphodn

@monsieurtanuki monsieurtanuki merged commit 3a4c0c9 into openfoodfacts:develop Jul 5, 2024
6 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon for your review, and enjoy your holidays!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants