Skip to content

8361423: Add IPSupport::printPlatformSupport to java/net/NetworkInterface/IPv4Only.java #26265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ayushrigal
Copy link

@ayushrigal ayushrigal commented Jul 11, 2025

This is part of a series of diagnostic output updates to java.net tests to assist in the analysis of failures in IPv6 only environments
for Linux there is not IPv4 configuration but the IPv4 stack remains enabled
For macOS, and windows the IPv4 stacks are disabled, and IPv4 configuration removed

add IPSupport::printPlatformSupport(System.out);

to the start of main


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Issue

  • JDK-8361423: Add IPSupport::printPlatformSupport to java/net/NetworkInterface/IPv4Only.java (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26265/head:pull/26265
$ git checkout pull/26265

Update a local copy of the PR:
$ git checkout pull/26265
$ git pull https://git.openjdk.org/jdk.git pull/26265/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26265

View PR using the GUI difftool:
$ git pr show -t 26265

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26265.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Jul 11, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 11, 2025

Hi @ayushrigal, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user ayushrigal" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Jul 11, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8361423: Add IPSupport::printPlatformSupport to java/net/NetworkInterface/IPv4Only.java 8361423: Add IPSupport::printPlatformSupport to java/net/NetworkInterface/IPv4Only.java Jul 11, 2025
@openjdk
Copy link

openjdk bot commented Jul 11, 2025

@ayushrigal The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@@ -35,6 +35,7 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a 2025 to the copyright at the top:

 * Copyright (c) 2010, 2025, Oracle and/or its affiliates. All rights reserved.

@@ -35,6 +35,7 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Could you please change the wildcard imports to explicit ones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
net [email protected] oca Needs verification of OCA signatory status
Development

Successfully merging this pull request may close these issues.

2 participants