Skip to content

8361423: Add IPSupport::printPlatformSupport to java/net/NetworkInterface/IPv4Only.java #26265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −4
Open

8361423: Add IPSupport::printPlatformSupport to java/net/NetworkInterface/IPv4Only.java #26265

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b377bf5
8361423: Add IPSupport::printPlatformSupport to java/net/NetworkInter…
ayushrigal Jul 10, 2025
4527293
8361423: Add IPSupport::printPlatformSupport to java/net/NetworkInter…
ayushrigal Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions test/jdk/java/net/NetworkInterface/IPv4Only.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2010, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2010, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -29,12 +29,18 @@
*/


import java.net.*;
import java.util.*;

import jdk.test.lib.net.IPSupport;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a 2025 to the copyright at the top:

 * Copyright (c) 2010, 2025, Oracle and/or its affiliates. All rights reserved.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Could you please change the wildcard imports to explicit ones

import java.net.Inet6Address;
import java.net.InetAddress;
import java.net.NetworkInterface;
import java.net.SocketException;
import java.util.Enumeration;

public class IPv4Only {
public static void main(String[] args) throws Exception {
IPSupport.printPlatformSupport(System.out);
if (IPSupport.hasIPv4()) {
System.out.println("Testing IPv4");
Enumeration<NetworkInterface> nifs = NetworkInterface.getNetworkInterfaces();
Expand All @@ -43,7 +49,7 @@ public static void main(String[] args) throws Exception {
Enumeration<InetAddress> addrs = nif.getInetAddresses();
while (addrs.hasMoreElements()) {
InetAddress hostAddr = addrs.nextElement();
if ( hostAddr instanceof Inet6Address ){
if ( hostAddr instanceof Inet6Address){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Ayush, while you are changing this, you can additionally format that line as follows:

if (hostAddr instanceof Inet6Address) {

throw new RuntimeException( "NetworkInterfaceV6List failed - found v6 address " + hostAddr.getHostAddress() );
}
}
Expand Down