Skip to content

8361827: [TESTBUG] serviceability/HeapDump/UnmountedVThreadNativeMethodAtTop.java throws OutOfMemoryError #26278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

reinrich
Copy link
Member

@reinrich reinrich commented Jul 12, 2025

This pr makes sure to call System.gc() before each test in UnmountedVThreadNativeMethodAtTop.java

The intention is to get rid of unreachable objects representing loaded heap dumps from previous tests.

This prevents OutOfMemoryErrors. Parsing the smaller dumps is faster too.

The PR also includes a reproducer for convenient testing of the pr.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361827: [TESTBUG] serviceability/HeapDump/UnmountedVThreadNativeMethodAtTop.java throws OutOfMemoryError (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26278/head:pull/26278
$ git checkout pull/26278

Update a local copy of the PR:
$ git checkout pull/26278
$ git pull https://git.openjdk.org/jdk.git pull/26278/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26278

View PR using the GUI difftool:
$ git pr show -t 26278

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26278.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 12, 2025

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 12, 2025

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361827: [TESTBUG] serviceability/HeapDump/UnmountedVThreadNativeMethodAtTop.java throws OutOfMemoryError

Reviewed-by: clanger, syan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@reinrich reinrich changed the title 8361602 testbug unmounted v thread native method at top oom 2 8361827: [TESTBUG] serviceability/HeapDump/UnmountedVThreadNativeMethodAtTop.java throws OutOfMemoryError Jul 12, 2025
@openjdk
Copy link

openjdk bot commented Jul 12, 2025

@reinrich The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@reinrich reinrich marked this pull request as ready for review July 14, 2025 07:27
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 14, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 14, 2025

Webrevs

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and likely improves test performance and stability.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 14, 2025
@reinrich
Copy link
Member Author

Thanks!
/integrate

@openjdk
Copy link

openjdk bot commented Jul 16, 2025

Going to push as commit cbb3d23.
Since your change was applied there have been 48 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 16, 2025
@openjdk openjdk bot closed this Jul 16, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 16, 2025
@openjdk
Copy link

openjdk bot commented Jul 16, 2025

@reinrich Pushed as commit cbb3d23.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability [email protected]
Development

Successfully merging this pull request may close these issues.

3 participants