Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8345146: [PPC64] Make intrinsic conversions between bit representations of half precision values and floats #1295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Dec 27, 2024

Almost clean backport of JDK-8345146. Two hunks had to be integrated manually due to unrelated differences in the context. The test updates had to be integrated manually because the RISCV part is not backported. TestFloat16VectorConvChain.java is not in 21u (introduced by openjdk/jdk@55fd1ed).

Original PR with performance numbers: openjdk/jdk#22433


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8345146 needs maintainer approval

Issue

  • JDK-8345146: [PPC64] Make intrinsic conversions between bit representations of half precision values and floats (Enhancement - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1295/head:pull/1295
$ git checkout pull/1295

Update a local copy of the PR:
$ git checkout pull/1295
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1295/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1295

View PR using the GUI difftool:
$ git pr show -t 1295

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1295.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 27, 2024

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 27, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport b42d79eb6a6d497dc63718c2854609bebca4498c 8345146: [PPC64] Make intrinsic conversions between bit representations of half precision values and floats Dec 27, 2024
@openjdk
Copy link

openjdk bot commented Dec 27, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 27, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 27, 2024

Webrevs

Copy link
Member

@reinrich reinrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Cheers, Richard.

@openjdk
Copy link

openjdk bot commented Jan 15, 2025

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@TheRealMDoerr
Copy link
Contributor Author

Thanks for the review!

@TheRealMDoerr
Copy link
Contributor Author

/approval request JDK-8289551 is a JDK20 feature. It's very slow without the intrinsics. That impacts some of the jtreg tests, too. Therefore, I'm requesting JDK21u backport. Performance numbers are shown in the original PR. x86_64 and aarch64 have the intrinsics backported even to JDK20 (JDK-8302976). The backport is almost clean, has been reviewed and tested for several weeks.

@openjdk
Copy link

openjdk bot commented Jan 15, 2025

@TheRealMDoerr
8345146: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants