-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8345146: [PPC64] Make intrinsic conversions between bit representations of half precision values and floats #1295
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Cheers, Richard.
|
Thanks for the review! |
/approval request JDK-8289551 is a JDK20 feature. It's very slow without the intrinsics. That impacts some of the jtreg tests, too. Therefore, I'm requesting JDK21u backport. Performance numbers are shown in the original PR. x86_64 and aarch64 have the intrinsics backported even to JDK20 (JDK-8302976). The backport is almost clean, has been reviewed and tested for several weeks. |
@TheRealMDoerr |
Almost clean backport of JDK-8345146. Two hunks had to be integrated manually due to unrelated differences in the context. The test updates had to be integrated manually because the RISCV part is not backported. TestFloat16VectorConvChain.java is not in 21u (introduced by openjdk/jdk@55fd1ed).
Original PR with performance numbers: openjdk/jdk#22433
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1295/head:pull/1295
$ git checkout pull/1295
Update a local copy of the PR:
$ git checkout pull/1295
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1295/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1295
View PR using the GUI difftool:
$ git pr show -t 1295
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1295.diff
Using Webrev
Link to Webrev Comment