Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Inconsistent dates between session date and encounter date #77

Conversation

icrc-jofrancisco
Copy link
Contributor

@icrc-jofrancisco icrc-jofrancisco commented Mar 19, 2024

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • My work includes tests or is validated by existing tests.

Summary

This pull request addresses the issue of inconsistent dates between session date and encounter date. Inconsistent dates can lead to confusion and errors in the system, impacting the reliability and usability of the application. The fix ensures that session dates and encounter dates are synchronized properly, resolving any discrepancies and promoting data integrity.

The proposed fix ensures that the encounter date aligns with the session date, providing users with the expected behavior.

Screenshots

Session date
image

Encounter date:
image

The reason the input is disabled is because there is a parallel development in the form-entry-app which, if the date is pre-filled, makes no sense to change it.
More details here.

Thanks,

Related Issue

Other

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @icrc-jofrancisco!

@denniskigen denniskigen merged commit 0443a9e into openmrs:main Mar 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants