Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Disable encounter date field when pre-filled #1747

Merged

Conversation

icrc-jofrancisco
Copy link
Contributor

@icrc-jofrancisco icrc-jofrancisco commented Mar 19, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This pull request addresses the issue where the encounter field remains enable when the encounter date is previously filled using pre-filled questions. This situation commonly arises during fast data entry, especially in group sessions where the encounter date matches the group session date. In such cases, the encounter date is already determined and should not be modified, hence disabling the input field prevents inadvertent changes.

Editing or creating new forms without using pre-filled data (normal use) remains the same.

Check the fast-data-entry pull request here.

Screenshots

image

Related Issue

Other

Thanks,

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @icrc-jofrancisco!

@denniskigen denniskigen merged commit 69bc41d into openmrs:main Mar 26, 2024
6 checks passed
@denniskigen denniskigen mentioned this pull request May 16, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants