Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Added start date to cohort payload #78

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

icrc-psousa
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • My work includes tests or is validated by existing tests.

Summary

Screenshots

Related Issue

Other

startDate: startDate,
cohortMembers: patientList.map((p) => ({
patient: p.uuid,
startDate: startDate,
Copy link
Member

@denniskigen denniskigen Mar 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find the relevant info on whether cohortMembers supports a startDate property, @ibacher, @dkayiwa. Could you verify this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should.

I don't love defaulting this to the current date. This should probably be something the user can edit when adding a member to the group.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that sound reasonable, @icrc-psousa?

jona42-ui and others added 5 commits March 26, 2024 07:41
* (chore)Migrate to newer transifex version

* Add `resource_name`

---------

Co-authored-by: Dennis Kigen <[email protected]>
* Patient sorting by name

* Fixed session patient list toggle issue

* Removed unnecessary div tag

* Use name instead of deprecated extensionSlotName property

* Adjusted AttendanceTable rendering to prevent undefined patient issues

* Fixed AttendanceTable

* Added cleanup function to SortedPatientLists effect

* Consider only patient name and not id when sorting

* Refactored patient list ordering

* Removed unnecessary sort on reducer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants