Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Added start date to cohort payload #78

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

(fix) Added start date to cohort payload #78

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1e0a3b4
Added start date to cohort payload
icrc-psousa Mar 22, 2024
0443a9e
(fix) Inconsistent dates between session date and encounter date (#77)
icrc-jofrancisco Mar 25, 2024
e901873
(feat) Add session and cohort identifiers for group sessions (#72)
icrc-jofrancisco Mar 25, 2024
2d2a5ed
(chore) Migrate to newer transifex version (#68)
jona42-ui Mar 26, 2024
9393be2
(chore) Bump dependencies and setup tooling (#64)
denniskigen Mar 27, 2024
0493326
(feat) Patient name sorting (#76)
icrc-psousa Apr 1, 2024
1a81463
Added start date to cohort payload
icrc-psousa Mar 22, 2024
e755b0b
Merge remote-tracking branch 'origin/fix/cohort-start-date' into fix/…
icrc-psousa Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/add-group-modal/AddGroupModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,10 +206,15 @@ const AddGroupModal = ({

const handleSubmit = () => {
if (validate()) {
const startDate = new Date().toISOString();
post({
uuid: cohortUuid,
name: name,
cohortMembers: patientList.map((p) => ({ patient: p.uuid })),
startDate: startDate,
cohortMembers: patientList.map((p) => ({
patient: p.uuid,
startDate: startDate,
Copy link
Member

@denniskigen denniskigen Mar 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find the relevant info on whether cohortMembers supports a startDate property, @ibacher, @dkayiwa. Could you verify this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should.

I don't love defaulting this to the current date. This should probably be something the user can edit when adding a member to the group.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that sound reasonable, @icrc-psousa?

})),
});
if (onPostSubmit) {
onPostSubmit();
Expand Down