ci: fix e2e report workflow missing netlify CLI
#2673
Merged
+39,796
−12,470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report 0%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
serhalp
force-pushed
the
ci/fix-e2e-report-missing-ntl
branch
2 times, most recently
from
94e28fc
to
9bf4485
Compare
Ubuntu 24.04 (now ubuntu-latest) has removed the `netlify` CLI :( We were installing it manually in some CI workflows, but not the e2e report one, which started failing. This fixes that by pulling in the easy parts of #2484.
serhalp
force-pushed
the
ci/fix-e2e-report-missing-ntl
branch
from
9bf4485
to
1c6046e
Compare
serhalp
force-pushed
the
ci/fix-e2e-report-missing-ntl
branch
from
1c6046e
to
a14fb6f
Compare
serhalp
commented
Oct 16, 2024
| ntl deploy --build --cwd e2e-report | ||
| npx netlify deploy --build --cwd e2e-report |
There was a problem hiding this comment.
All the npx changes are because when binaries are installed locally, GitHub doesn't automatically add ./node_modules/.bin to the PATH. Just using npx is the right approach I think.
lukasholzer
reviewed
Oct 16, 2024
| npm i -g [email protected] | ||
| netlify login | ||
| # Control netlify-cli as a regular dev dep but expose it globally for test fixtures to use | ||
| npm install -g "netlify-cli@$(npm list --json --depth=0 netlify-cli | jq -r ".dependencies[\"netlify-cli\"].version")" |
lukasholzer
reviewed
Oct 16, 2024
| # https://netlify.slack.com/archives/C07686YAY13/p1718139257978049 is resolved. | ||
| npm i -g [email protected] | ||
| netlify login | ||
| # Control netlify-cli as a regular dev dep but expose it globally for test fixtures to use |
There was a problem hiding this comment.
NIT: you could pull this out into a reusable action in github actions.
Something like .github/actions/netlify
name: 'Install Netlify CLI'
description: some description
runs:
using: 'composite'
steps:
- run: |
# Control netlify-cli as a regular dev dep but expose it globally for test fixtures to use
npm install -g "netlify-cli@$(npm list --json --depth=0 netlify-cli | jq -r ".dependencies[\"netlify-cli\"].version")"
npx netlify login
serhalp
added a commit
that referenced
this pull request
Oct 16, 2024
We only install this pseudo-monorepo-package's deps in the e2e report CI workflow, not the root deps. Follow-up to #2673.
serhalp
added a commit
that referenced
this pull request
Oct 16, 2024
We only install this pseudo-monorepo-package's deps in the e2e report CI workflow, not the root deps. Follow-up to #2673.
serhalp
added a commit
that referenced
this pull request
Oct 16, 2024
Since it doesn't run on all PRs, I didn't notice it needed a slightly different config when I changed this in #2673. This workflow checks out next-runtime in one directory and next.js in another, so we need to specify a working directory.
serhalp
added a commit
that referenced
this pull request
Oct 16, 2024
Since it doesn't run on all PRs, I didn't notice it needed a slightly different config when I changed this in #2673. This workflow checks out next-runtime in one directory and next.js in another, so we need to specify a working directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu 24.04 (now ubuntu-latest) has removed the
netlifyCLI :(We were installing it manually in some CI workflows, but not the e2e report one, which started failing.
This fixes that by reviving #2484, i.e. using netlify-cli as a dev dep everywhere. In cases where we're running a test fixture in another working directory, I've added a CI step that sort of "promotes" the dev dep to a global dep. It's a bit funny but I think it's a good compromise. Now netlify-cli is entirely controlled via package.json and can receive deterministic updates via Renovate like anything else.
Supersedes #2484.