Export consultation results to CSV #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exports it following the exact same table format we render in the page that includes membership data. It adheres to Decidim's exporter's conventions which send an email with a zip containing the CSV file.
sauloperez
commented
Oct 5, 2020
app/controllers/decidim/action_delegator/admin/exports_controller.rb
Outdated
Show resolved
Hide resolved
app/jobs/decidim/action_delegator/export_consultation_results_job.rb
Outdated
Show resolved
Hide resolved
app/jobs/decidim/action_delegator/export_consultation_results_job.rb
Outdated
Show resolved
Hide resolved
app/controllers/decidim/action_delegator/admin/exports_controller.rb
Outdated
Show resolved
Hide resolved
sauloperez
commented
Oct 5, 2020
app/views/decidim/consultations/admin/consultations/results.html.erb
Outdated
Show resolved
Hide resolved
sauloperez
force-pushed
the
export-results-to-csv
branch
from
90db955 to
6ed4c1e
Compare
The goal is to avoid devs thinking that this is a generic controller that deals with all kinds of exports.
So we don't end up with an N+1.
sauloperez
force-pushed
the
export-results-to-csv
branch
from
b881752 to
c453152
Compare
sauloperez
force-pushed
the
export-results-to-csv
branch
from
c453152 to
008a044
Compare
1 task
verarojman
approved these changes
Oct 7, 2020
There was a problem hiding this comment.
Hi @sauloperez, great job! 🌟 I left some suggestions (most of them concerning style) though everything looks good to me (after a painful setup of the environment required to test it 😭).
app/jobs/decidim/action_delegator/export_consultation_results_job.rb
Outdated
Show resolved
Hide resolved
app/queries/decidim/action_delegator/responses_by_membership.rb
Outdated
Show resolved
Hide resolved
app/views/decidim/consultations/admin/consultations/results.html.erb
Outdated
Show resolved
Hide resolved
sauloperez
force-pushed
the
export-results-to-csv
branch
from
c621ad2 to
f68e9c6
Compare
This way users will have a named in Catalan which will be more user friendly for them.
sauloperez
force-pushed
the
export-results-to-csv
branch
from
f68e9c6 to
f51d063
Compare
And reuse a single action. The meaning is the same.
sauloperez
commented
Oct 9, 2020
| @@ -7,6 +7,13 @@ | |||
| / | |||
| <%= t "decidim.admin.consultations.results.participants", count: current_consultation.total_participants %> | |||
| </span> | |||
| <span id="export-consultation-results" class="button--title"> | |||
| <% if allowed_to?(:export_consultation_results, :consultation, { consultation: current_consultation }, [::Decidim::ActionDelegator::Permissions]) %> | |||
There was a problem hiding this comment.
This is yet another example of what we need to solve in #24. Permissions are increasingly growing in complexity and that hampers changeability.
In this case, because the controller is on Decidim's core, it does not return our permissions chain, using Decidim::Consultations::Permissions to handle :export_consultation_results.
I'll move on with this and fix it in #24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exports the consultation's results following the exact same table format we render on the page that includes membership data.
It adheres to Decidim's exporter's conventions which send an email with a zip containing the CSV file. Note it also allows you to translate the filename 👌 Thanks @verarojman !
📸
Table
with unpublished results
with published results
Email with 📎
CSV file
Missing