int literals should return an Integer value

[timtebeek]

What's changed?

What's your motivation?

As discovered on

• SimplifyWebTestClientCalls does not work on Kotlin code rewrite-spring#663

[github-actions]

Some suggestions could not be made:

• src/main/java/org/openrewrite/kotlin/KotlinTypeGoat.kt
  • lines 25-25
• src/test/resources/KotlinTypeGoat.kt
  • lines 25-25

[barbulescu]

@timtebeek maybe this is the reason: https://github.com/JetBrains/kotlin/blob/403acc0dee98791e7f2a068feb5b09f13c7909db/compiler/psi/src/org/jetbrains/kotlin/parsing/ParseUtils.kt#L38

[timtebeek]

Thanks yes that looks to be it! Now we have to see at which point we can alter that value :)

[barbulescu]

Maybe here:

    @Override
    public J visitConstantExpression(KtConstantExpression expression, ExecutionContext data) {
        IElementType elementType = expression.getElementType();
        Object value;
        if (elementType == KtNodeTypes.INTEGER_CONSTANT || elementType == KtNodeTypes.FLOAT_CONSTANT) {
            value = ParseUtilsKt.parseNumericLiteral(expression.getText(), elementType);
            if (value instanceof Long) {
                int intValue = ((Long) value).intValue();
                if (Objects.equals(value, (long) intValue)) {
                    value = intValue;
                }
            }
        } else if (elementType == KtNodeTypes.BOOLEAN_CONSTANT) {

[timtebeek]

Nice, thanks! Went for a slightly different approach to ensure true longs remain longs. With that I think we're good! :)

[barbulescu]

Kotlin forum is in read-only mode so I created a bug report.

[timtebeek]

Much appreciated! I'll have another look at your PR in rewrite-spring now that this is sorted. :)

• SimplifyWebTestClientCalls does not work on Kotlin code rewrite-spring#663