SimplifyWebTestClientCalls does not work on Kotlin code

[barbulescu]

What's changed?

Add support for both int (Java) and long (Kotlin) status code types.

What's your motivation?

Have this recipe work on Kotlin code.

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Followed the instructions on Discord.

Wanted to add support for HttpStatus argument but one extra step is to remove the import if not used anywhere else.
Decided to have a follow-up PR for this fix.

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[timtebeek]

Thanks a lot @barbulescu ; you've stumbled upon an issue with the underlying KotlinParser, which I've logged here:

• int literals should return an Integer value rewrite-kotlin#624

That meant that literals of the type int where returning a Long value as you've discovered, which then needed the casts seen here. Ideally we fix this upstream; I'll try my hand at that first.

[github-actions]

Some suggestions could not be made:

• src/main/java/org/openrewrite/java/spring/http/SimplifyWebTestClientCalls.java
  • lines 30-31

[timtebeek]

You've uncovered another imperfection with the way we represent types that come from Java libraries in Kotlin:

• Method matcher should match Java primitive types in Kotlin rewrite-kotlin#626

That'll negatively affect our ability to match methods used in Kotlin code, such that existing recipes might not match where they should. We should take a closer look in rewrite-kotlin in how that type information is built up, and ensure Java types are used, or adjust the matcher to match both Java and Kotlin types for int and kotlin.Int` and others.

[timtebeek]

Thanks for the necessary adjustments to make this work for Kotlin as well, and helping uncover two imperfections upstream in rewrite-kotlin, and the help in getting one of those cleared out already. We'll merge this iteration and can separately look to cover the HttpStatus case you're after indeed.