Switch to inclusion table for T1OO handling #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The handling of different values of the `?include_t1oo` parameter is already tested in `test_tpp_backend_modify_dsn`. Here we want to test the query behaviour.
evansd
force-pushed
the
evansd/t1oo-update-v2
branch
from
5b32e54
to
09451aa
Compare
We now only include patients who exist in a specific list of allowed patients. This allows TPP to apply more complex logic in the inclusion/exclusion criteria than just the presence of an opt-out record.
This affects whether or not the initial join is with the `Patient` table or a temporary table and so we should test that the T1OO code correctly handles both cases.
These were sensitive to the exact number of joins the T1OO logic used.
evansd
force-pushed
the
evansd/t1oo-update-v2
branch
from
09451aa
to
2eb5f39
Compare
rebkwok
approved these changes
Aug 2, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the T1OO logic to use a table of explicitly allowed patients, rather than a table of exclusions. This allows TPP to apply more complex criteria in determining the appropriate set of patients.