-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional logging for Azure repository stats #12079
Add additional logging for Azure repository stats #12079
Conversation
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
❌ Gradle check result for 7679601: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Compatibility status:Checks if related components are compatible with change ed90c5d Incompatible componentsIncompatible components: [https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/cross-cluster-replication.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/sql.git] |
...nternalClusterTest/java/org/opensearch/repositories/azure/AzureBlobStoreRepositoryTests.java
Outdated
Show resolved
Hide resolved
Building failing? Please fix or retrigger the build |
Signed-off-by: Sarat Vemulapalli <[email protected]>
Yeah pretty weird, I haven't seen this. Looks like a network problem, not sure if its the tool server or jenkins CI.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12079 +/- ##
============================================
- Coverage 71.43% 71.37% -0.07%
+ Complexity 59527 59499 -28
============================================
Files 4925 4925
Lines 279513 279513
Branches 40646 40643 -3
============================================
- Hits 199674 199494 -180
- Misses 63226 63473 +247
+ Partials 16613 16546 -67 ☔ View full report in Codecov by Sentry. |
...nternalClusterTest/java/org/opensearch/repositories/azure/AzureBlobStoreRepositoryTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sarat Vemulapalli <[email protected]>
* Adding logging for AzureStats Signed-off-by: Sarat Vemulapalli <[email protected]> * Debugging Signed-off-by: Sarat Vemulapalli <[email protected]> * Removing debugging lines Signed-off-by: Sarat Vemulapalli <[email protected]> * Addressing comments Signed-off-by: Sarat Vemulapalli <[email protected]> * Addressing feedback 2 Signed-off-by: Sarat Vemulapalli <[email protected]> --------- Signed-off-by: Sarat Vemulapalli <[email protected]> Signed-off-by: Sarat Vemulapalli <[email protected]> (cherry picked from commit 16c5257) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Adding logging for AzureStats * Debugging * Removing debugging lines * Addressing comments * Addressing feedback 2 --------- (cherry picked from commit 16c5257) Signed-off-by: Sarat Vemulapalli <[email protected]> Signed-off-by: Sarat Vemulapalli <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…#12079) * Adding logging for AzureStats Signed-off-by: Sarat Vemulapalli <[email protected]> * Debugging Signed-off-by: Sarat Vemulapalli <[email protected]> * Removing debugging lines Signed-off-by: Sarat Vemulapalli <[email protected]> * Addressing comments Signed-off-by: Sarat Vemulapalli <[email protected]> * Addressing feedback 2 Signed-off-by: Sarat Vemulapalli <[email protected]> --------- Signed-off-by: Sarat Vemulapalli <[email protected]> Signed-off-by: Sarat Vemulapalli <[email protected]>
…#12079) * Adding logging for AzureStats Signed-off-by: Sarat Vemulapalli <[email protected]> * Debugging Signed-off-by: Sarat Vemulapalli <[email protected]> * Removing debugging lines Signed-off-by: Sarat Vemulapalli <[email protected]> * Addressing comments Signed-off-by: Sarat Vemulapalli <[email protected]> * Addressing feedback 2 Signed-off-by: Sarat Vemulapalli <[email protected]> --------- Signed-off-by: Sarat Vemulapalli <[email protected]> Signed-off-by: Sarat Vemulapalli <[email protected]>
…#12079) * Adding logging for AzureStats Signed-off-by: Sarat Vemulapalli <[email protected]> * Debugging Signed-off-by: Sarat Vemulapalli <[email protected]> * Removing debugging lines Signed-off-by: Sarat Vemulapalli <[email protected]> * Addressing comments Signed-off-by: Sarat Vemulapalli <[email protected]> * Addressing feedback 2 Signed-off-by: Sarat Vemulapalli <[email protected]> --------- Signed-off-by: Sarat Vemulapalli <[email protected]> Signed-off-by: Sarat Vemulapalli <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Adding additional logging for Azure repository
testRequestStats
to dump the requests ended up on the blob store.These logs will only be printed when the tests fails.
The intention is to understand the number of calls received by Azure repo. The logger only dumps these when there is a failure in CI, shouldnot really bloat our runs.
Background: Ran this test 7k times and it successfully passed. See #9859 (comment). Looking at the errors we definitely need more logs for the number of calls being made by the SDK and what we really received.
Sample logs:
Related Issues
#9859
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.