Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional logging for Azure repository stats #12079

Merged
merged 7 commits into from
Jan 31, 2024
Merged

Add additional logging for Azure repository stats #12079

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6473dcf
Adding logging for AzureStats
saratvemulapalli Jan 29, 2024
476df65
Debugging
saratvemulapalli Jan 29, 2024
7679601
Removing debugging lines
saratvemulapalli Jan 29, 2024
ad069de
Merge branch 'main' into azure-flaky-test
saratvemulapalli Jan 30, 2024
1f13238
Addressing comments
saratvemulapalli Jan 30, 2024
e71f7e8
Addressing feedback 2
saratvemulapalli Jan 31, 2024
ed90c5d
Merge branch 'main' into azure-flaky-test
saratvemulapalli Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...rnalClusterTest/java/org/opensearch/repositories/azure/AzureBlobStoreRepositoryTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@
import com.azure.storage.common.implementation.Constants;
import com.azure.storage.common.policy.RequestRetryOptions;
import com.azure.storage.common.policy.RetryPolicyType;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.opensearch.common.SuppressForbidden;
import org.opensearch.common.regex.Regex;
import org.opensearch.common.settings.MockSecureSettings;
Expand Down Expand Up @@ -188,6 +190,7 @@ protected String requestUniqueId(final HttpExchange exchange) {
@SuppressForbidden(reason = "this test uses a HttpServer to emulate an Azure endpoint")
private static class AzureHTTPStatsCollectorHandler extends HttpStatsCollectorHandler {

private static final Logger testLogger = LogManager.getLogger(AzureHTTPStatsCollectorHandler.class);
private static final Pattern listPattern = Pattern.compile("GET /[a-zA-Z0-9]+\\??.+");
private static final Pattern getPattern = Pattern.compile("GET /[^?/]+/[^?/]+\\??.*");

Expand All @@ -197,6 +200,7 @@ private AzureHTTPStatsCollectorHandler(HttpHandler delegate) {

@Override
protected void maybeTrack(String request, Headers headers) {
testLogger.info(request, headers);
if (getPattern.matcher(request).matches()) {
trackRequest("GetBlob");
} else if (Regex.simpleMatch("HEAD /*/*", request)) {
Expand Down
Loading