Bump Java to 21 #1842
Bump Java to 21 #1842
Conversation
Signed-off-by: Derek Ho <[email protected]>
derek-ho
requested review from
ps48,
kavithacm,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
Signed-off-by: Derek Ho <[email protected]>
| @@ -23,6 +23,9 @@ jobs: | |||
| # need to switch to root so that github actions can install runner binary on container without permission issues. | |||
| options: --user root | |||
|
|
|||
| env: | |||
| ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true | |||
There was a problem hiding this comment.
what is this? it shouldn't use node
There was a problem hiding this comment.
It is a change on github runners:
On June 30th 2024, we will change the default from Node16 to Node20.
To opt out of this and continue using Node16 while it is still available in the runner, you can choose to set ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true
There was a problem hiding this comment.
but do we need it in this workflow? this workflow doesn't use node
There was a problem hiding this comment.
This is coming from the container image this workflow step is being run on:
container:
# using the same image which is used by opensearch-build team to build the OpenSearch Distribution
# this image tag is subject to change as more dependencies and updates will arrive over time
image: ${{ needs.Get-CI-Image-Tag.outputs.ci-image-version-linux }}.
That is using AL2, which is causing the incompatibility.
There was a problem hiding this comment.
i understand the incompatibility, the question was where is it using node. i'm assuming it's the checkout action or github action internal impl
There was a problem hiding this comment.
Yes i think the checkout action uses node, did a quick search: https://github.com/search?q=repo%3Aactions%2Fcheckout%20node&type=code
Description
Bump Java to 21. Adds unsecure flag to prevent build failures.
Issues Resolved
Fix: #1830
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.