Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Java to 21 #1842

Merged
merged 2 commits into from
Jul 9, 2024
+5 −2
Merged

Bump Java to 21 #1842

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11a0f4d
Bump to 21
derek-ho Jul 9, 2024
5adc048
Add unsecure node version
derek-ho Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/opensearch-observability-test-and-build-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
# Run all jobs
fail-fast: false
matrix:
java: [11, 17, 21]
java: [21]
runs-on: ubuntu-latest
container:
# using the same image which is used by opensearch-build team to build the OpenSearch Distribution
Expand All @@ -23,6 +23,9 @@ jobs:
# need to switch to root so that github actions can install runner binary on container without permission issues.
options: --user root

env:
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this? it shouldn't use node

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a change on github runners:

On June 30th 2024, we will change the default from Node16 to Node20.
To opt out of this and continue using Node16 while it is still available in the runner, you can choose to set ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but do we need it in this workflow? this workflow doesn't use node

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is coming from the container image this workflow step is being run on:

container:
      # using the same image which is used by opensearch-build team to build the OpenSearch Distribution
      # this image tag is subject to change as more dependencies and updates will arrive over time
      image: ${{ needs.Get-CI-Image-Tag.outputs.ci-image-version-linux }}.

That is using AL2, which is causing the incompatibility.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i understand the incompatibility, the question was where is it using node. i'm assuming it's the checkout action or github action internal impl

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes i think the checkout action uses node, did a quick search: https://github.com/search?q=repo%3Aactions%2Fcheckout%20node&type=code


steps:
- uses: actions/checkout@v1

Expand Down Expand Up @@ -65,7 +68,7 @@ jobs:
# Run all jobs
fail-fast: false
matrix:
java: [11, 17, 21]
java: [21]
os: [windows-latest, macos-latest]
runs-on: ${{ matrix.os }}

Expand Down
Loading