Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Faiss byte vector support blog #3458
Add Faiss byte vector support blog #3458
Changes from 2 commits
6201283
3f019b2
9b6853d
8934fe1
4206c40
dfd36c6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 25 in _posts/2024-11-22-faiss-byte-vector.md
GitHub Actions / style-job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 92, first sentence: "precision in recall" => "recall precision"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 99: Should we define SIMD?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to lowercase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Dimension of vector" => "Vector dimension"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"HNSW-byte" is hyphenated in the third column header but not in the ninth. Is that intentional, or should they match? It's also not hyphenated in the headers in the next table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"with larger vector dimensions" => "when using larger vector dimensions"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's ok as is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 160, end of last sentence: "are decoded back into the original signed 8-bit vectors for the purpose of distance computation"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's understandable in the original form.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It reads as though "the" should precede "signed", though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: This section should probably precede the conclusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 185, first sentence: "compression level in Faiss" => "Faiss compression level"?
Check failure on line 191 in _posts/2024-11-22-faiss-byte-vector.md
GitHub Actions / style-job
Check failure on line 191 in _posts/2024-11-22-faiss-byte-vector.md
GitHub Actions / style-job
Check failure on line 191 in _posts/2024-11-22-faiss-byte-vector.md
GitHub Actions / style-job
Check failure on line 191 in _posts/2024-11-22-faiss-byte-vector.md
GitHub Actions / style-job
Check failure on line 191 in _posts/2024-11-22-faiss-byte-vector.md
GitHub Actions / style-job
Check failure on line 191 in _posts/2024-11-22-faiss-byte-vector.md
GitHub Actions / style-job
Check failure on line 191 in _posts/2024-11-22-faiss-byte-vector.md
GitHub Actions / style-job
Check failure on line 191 in _posts/2024-11-22-faiss-byte-vector.md
GitHub Actions / style-job