Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the job scheduler parser, action listeners, and multi-node test #1157

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

jowg-amazon
Copy link
Collaborator

Description

Fixes the the job scheduler parser to be compatible with detector configured with threat intel, clean up the action listeners, and fixes multi-node test

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
@jowg-amazon
Copy link
Collaborator Author

Multi-node test is failing on a different failure than createThreatIntelMonitor test

@jowg-amazon
Copy link
Collaborator Author

Ran ./gradlew ':integTest' --tests "org.opensearch.securityanalytics.resthandler.ThreatIntelMonitorRestApiIT.testCreateThreatIntelMonitor" -PnumNodes=3 -PcustomDistributionUrl="https://artifacts.opensearch.org/snapshots/core/opensearch/3.0.0-SNAPSHOT/opensearch-min-3.0.0-SNAPSHOT-darwin-x64-latest.tar.gz" -Dtests.iters=100 and tests passed

@jowg-amazon jowg-amazon merged commit b8496a9 into opensearch-project:main Jul 12, 2024
13 of 16 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 12, 2024
…1157)

* fix job parser

Signed-off-by: Joanne Wang <[email protected]>

* fix listener.onFailure

Signed-off-by: Joanne Wang <[email protected]>

* fix flaky create threat intel monitor test

Signed-off-by: Joanne Wang <[email protected]>

---------

Signed-off-by: Joanne Wang <[email protected]>
(cherry picked from commit b8496a9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jowg-amazon pushed a commit that referenced this pull request Jul 12, 2024
…1157) (#1160)

* fix job parser



* fix listener.onFailure



* fix flaky create threat intel monitor test



---------


(cherry picked from commit b8496a9)

Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 12, 2024
…1157)

* fix job parser

Signed-off-by: Joanne Wang <[email protected]>

* fix listener.onFailure

Signed-off-by: Joanne Wang <[email protected]>

* fix flaky create threat intel monitor test

Signed-off-by: Joanne Wang <[email protected]>

---------

Signed-off-by: Joanne Wang <[email protected]>
(cherry picked from commit b8496a9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jowg-amazon added a commit that referenced this pull request Jul 15, 2024
…1157)

* fix job parser

Signed-off-by: Joanne Wang <[email protected]>

* fix listener.onFailure

Signed-off-by: Joanne Wang <[email protected]>

* fix flaky create threat intel monitor test

Signed-off-by: Joanne Wang <[email protected]>

---------

Signed-off-by: Joanne Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants