threat intel monitor bug fixes #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eirsep
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
jowg-amazon,
engechas,
goyamegh and
riysaxen-amzn
as code owners
Signed-off-by: Surya Sashank Nistala <[email protected]>
…ry and verify grouped listener wiring Signed-off-by: Surya Sashank Nistala <[email protected]>
eirsep
changed the title
Signed-off-by: Surya Sashank Nistala <[email protected]>
eirsep
force-pushed
the
threat_intel_bug_fixes
branch
from
5aca445 to
f8911b8
Compare
|
|
Signed-off-by: Surya Sashank Nistala <[email protected]>
jowg-amazon
reviewed
Sep 24, 2024
| @@ -281,6 +285,8 @@ public void testCreateThreatIntelMonitor() throws IOException { | |||
| String doc = String.format("{\"ip\":\"%s\", \"ip1\":\"%s\"}", val, val); | |||
| try { | |||
| indexDoc(index, "" + i++, doc); | |||
| indexDoc(index, "" + i++, String.format("{\"ip\":\"1.2.3.4\", \"ip1\":\"1.2.3.4\"}", val, val)); | |||
| indexDoc(index, "" + i++, String.format("{\"random\":\"%s\", \"random1\":\"%s\"}", val, val)); | |||
| } catch (IOException e) { | |||
| fail(); | |||
| } | |||
There was a problem hiding this comment.
Can we add a test scenario that replicates the case where the index being queried doesn't have any docs and it correctly catches the all shards failed and the No mapping found for [_seq_no] in order to sort on exception?
Signed-off-by: Surya Sashank Nistala <[email protected]>
jowg-amazon
approved these changes
Sep 24, 2024
sbcd90
approved these changes
Sep 24, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
* handle exception arising from trying to search with sort on empty index Signed-off-by: Surya Sashank Nistala <[email protected]> * add setting to test max term count in threat intel ioc scan terms query and verify grouped listener wiring Signed-off-by: Surya Sashank Nistala <[email protected]> * remove unused variable Signed-off-by: Surya Sashank Nistala <[email protected]> * avoid grouped listener being initiated with size 0 Signed-off-by: Surya Sashank Nistala <[email protected]> * add verification that empty index scan is handled gracefully Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 39c29d4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
* handle exception arising from trying to search with sort on empty index Signed-off-by: Surya Sashank Nistala <[email protected]> * add setting to test max term count in threat intel ioc scan terms query and verify grouped listener wiring Signed-off-by: Surya Sashank Nistala <[email protected]> * remove unused variable Signed-off-by: Surya Sashank Nistala <[email protected]> * avoid grouped listener being initiated with size 0 Signed-off-by: Surya Sashank Nistala <[email protected]> * add verification that empty index scan is handled gracefully Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 39c29d4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
* handle exception arising from trying to search with sort on empty index Signed-off-by: Surya Sashank Nistala <[email protected]> * add setting to test max term count in threat intel ioc scan terms query and verify grouped listener wiring Signed-off-by: Surya Sashank Nistala <[email protected]> * remove unused variable Signed-off-by: Surya Sashank Nistala <[email protected]> * avoid grouped listener being initiated with size 0 Signed-off-by: Surya Sashank Nistala <[email protected]> * add verification that empty index scan is handled gracefully Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 39c29d4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Sep 24, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
* handle exception arising from trying to search with sort on empty index Signed-off-by: Surya Sashank Nistala <[email protected]> * add setting to test max term count in threat intel ioc scan terms query and verify grouped listener wiring Signed-off-by: Surya Sashank Nistala <[email protected]> * remove unused variable Signed-off-by: Surya Sashank Nistala <[email protected]> * avoid grouped listener being initiated with size 0 Signed-off-by: Surya Sashank Nistala <[email protected]> * add verification that empty index scan is handled gracefully Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 39c29d4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
eirsep
pushed a commit
that referenced
this pull request
Sep 25, 2024
* handle exception arising from trying to search with sort on empty index * add setting to test max term count in threat intel ioc scan terms query and verify grouped listener wiring * remove unused variable * avoid grouped listener being initiated with size 0 * add verification that empty index scan is handled gracefully --------- (cherry picked from commit 39c29d4) Signed-off-by: Surya Sashank Nistala <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
eirsep
pushed a commit
that referenced
this pull request
Sep 25, 2024
* handle exception arising from trying to search with sort on empty index * add setting to test max term count in threat intel ioc scan terms query and verify grouped listener wiring * remove unused variable * avoid grouped listener being initiated with size 0 * add verification that empty index scan is handled gracefully --------- (cherry picked from commit 39c29d4) Signed-off-by: Surya Sashank Nistala <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
eirsep
pushed a commit
that referenced
this pull request
Sep 25, 2024
* handle exception arising from trying to search with sort on empty index * add setting to test max term count in threat intel ioc scan terms query and verify grouped listener wiring * remove unused variable * avoid grouped listener being initiated with size 0 * add verification that empty index scan is handled gracefully --------- (cherry picked from commit 39c29d4) Signed-off-by: Surya Sashank Nistala <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
handle exception arising from trying to search with sort on empty index: Sorting by
_seq_nofield fails on empty index as mapping isn't created yet. This failure is expected and needs to be handled to return empty list instead of throwing exception and calling it a monitor failureadd setting to test max term count in threat intel ioc scan terms query and verify grouped listener wiring:
Use grouped listener to execute parallel calls instead of submitting calls with same listener
Index out of bounds exception as wrong listener is used.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
#1319
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.