Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSL config for JDK PKCS setup #4999

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

willyborankin
Copy link
Collaborator

Description

Set the keystore_password by default same as the keystore_keypassword setting

Issues Resolved

#4961

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Fix issue opensearch-project#4961 by defaulting
the keystore_keypassword setting to the same value as the keystore_password

Signed-off-by: Andrey Pleskach <[email protected]>
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.41%. Comparing base (a3345ef) to head (7b448e5).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...rch/security/ssl/config/SslCertificatesLoader.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4999      +/-   ##
==========================================
- Coverage   71.50%   71.41%   -0.10%     
==========================================
  Files         334      334              
  Lines       22556    22557       +1     
  Branches     3589     3590       +1     
==========================================
- Hits        16129    16109      -20     
- Misses       4635     4655      +20     
- Partials     1792     1793       +1     
Files with missing lines Coverage Δ
...rch/security/ssl/config/SslCertificatesLoader.java 87.03% <66.66%> (-1.65%) ⬇️

... and 6 files with indirect coverage changes

@willyborankin willyborankin added the backport 2.x backport to 2.x branch label Dec 30, 2024
@cwperks cwperks merged commit 48be2af into opensearch-project:main Jan 16, 2025
41 of 43 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 16, 2025
Signed-off-by: Andrey Pleskach <[email protected]>
(cherry picked from commit 48be2af)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants