catch up with CI: rename controller's credentialsrequest to minify version #120

alebedev87 · 2023-11-14T14:30:34Z

…rsion

alebedev87 · 2023-11-14T16:06:01Z

/test ci/prow/e2e-aws-operator

openshift-ci · 2023-11-14T16:06:05Z

@alebedev87: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test ci-index-aws-load-balancer-operator-bundle
/test e2e-aws-operator
/test e2e-aws-rosa-operator
/test images
/test unit
/test verify

Use /test all to run all jobs.

In response to this:

/test ci/prow/e2e-aws-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alebedev87 · 2023-11-14T16:06:18Z

/test e2e-aws-rosa-operator

alebedev87 · 2023-11-14T16:25:09Z

/label docs-approved
/label qe-approved
/label px-approved

Proactive PR to prevent CI failures in the future.

openshift-ci-robot · 2023-11-14T22:17:47Z

@alebedev87: This pull request explicitly references no jira issue.

In response to this:

To catchup with this CI change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alebedev87 · 2023-11-14T22:18:09Z

/remove-label docs-approved
/remove-label qe-approved
/remove-label px-approved

alebedev87 · 2023-11-15T08:33:53Z

/test e2e-aws-rosa-operator

alebedev87 · 2023-11-15T11:53:54Z

/test e2e-aws-rosa-operator

alebedev87 · 2023-11-15T15:19:53Z

/test e2e-aws-rosa-operator

alebedev87 · 2023-11-22T14:09:09Z

/test e2e-aws-rosa-operator

openshift-ci · 2023-11-22T16:27:47Z

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

gcs278 · 2023-11-28T16:06:33Z

/assign

gcs278 · 2023-11-28T16:20:17Z

Makefile

@@ -79,7 +79,7 @@ IAMCTL_OUTPUT_FILE ?= iam_policy.go
 IAMCTL_GO_PACKAGE ?= awsloadbalancercontroller

 # File name of the generated CredentialsRequest CR.
-IAMCTL_OUTPUT_CR_FILE ?= ./hack/controller/controller-credentials-request.yaml
+IAMCTL_OUTPUT_CR_FILE ?= ./hack/controller/controller-credentials-request-minify.yaml


Is this file name minify even though it isn't technically minified in release-1.0? Or it actually minified?

It's actually minified. I changed the name of the file in main 1) to better reflect its contents, 2) because 2 versions of the credentialsrequest are not published: minified and not minified.

gcs278 · 2023-11-28T17:30:58Z

Simple fix for maintaining CI on release-1.0
/lgtm
/approve

openshift-ci · 2023-11-28T17:32:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gcs278

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [gcs278]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

alebedev87 · 2023-11-28T17:39:52Z

/label jira/valid-bug

Ref: openshift-eng/jira-lifecycle-plugin#71

openshift-ci · 2023-11-28T17:40:35Z

@alebedev87: Can not set label jira/valid-bug: Must be member in one of these teams: [openshift-patch-managers openshift-staff-engineers openshift-release-oversight]

In response to this:

/label jira/valid-bug

Ref: openshift-eng/jira-lifecycle-plugin#71

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alebedev87 · 2023-11-28T17:42:24Z

/label docs-approved
/label qe-apporved
/label px-approved

Minor change to sync with the CI step change, no need to ping all the parties.

openshift-ci · 2023-11-28T17:43:04Z

@alebedev87: The label(s) /label qe-apporved cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, rebase/manual, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label docs-approved
/label qe-apporved
/label px-approved

Minor change to sync with the CI step change, no need to ping all the parties.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-11-28T18:03:34Z

@alebedev87: This pull request references Jira Issue OCPBUGS-24040, which is invalid:

expected Jira Issue OCPBUGS-24040 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

To catchup with this CI change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alebedev87 · 2023-11-28T18:04:06Z

/remove-label docs-approved
/remove-label px-approved

alebedev87 · 2023-11-28T18:04:25Z

/jira refresh

openshift-ci-robot · 2023-11-28T18:04:29Z

@alebedev87: This pull request references Jira Issue OCPBUGS-24040, which is invalid:

expected Jira Issue OCPBUGS-24040 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alebedev87 · 2023-11-28T19:16:02Z

/jira refresh

openshift-ci-robot · 2023-11-28T19:16:06Z

@alebedev87: This pull request references Jira Issue OCPBUGS-24040, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
expected Jira Issue OCPBUGS-24040 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alebedev87 · 2023-11-28T19:16:45Z

/jira refresh

openshift-ci-robot · 2023-11-28T19:16:49Z

@alebedev87: This pull request references Jira Issue OCPBUGS-24040, which is invalid:

expected Jira Issue OCPBUGS-24040 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-11-28T19:18:42Z

@alebedev87: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

To catchup with this CI change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alebedev87 · 2023-11-28T19:18:43Z

/label docs-approved
/label qe-approved
/label px-approved

catch up with CI: rename controller's credentialsrequest to minify ve…

61459a9

…rsion

openshift-ci bot requested review from frobware and Miciah November 14, 2023 14:37

openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR qe-approved Signifies that QE has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Nov 14, 2023

alebedev87 changed the title ~~catch up with CI: rename controller's credentialsrequest to minify version~~ NO-JIRA: catch up with CI: rename controller's credentialsrequest to minify version Nov 14, 2023

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 14, 2023

openshift-ci bot removed docs-approved Signifies that Docs has signed off on this PR qe-approved Signifies that QE has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Nov 14, 2023

alebedev87 mentioned this pull request Nov 15, 2023

aws-load-balancer: update ocp version openshift/release#45653

Merged

openshift-ci bot assigned gcs278 Nov 28, 2023

gcs278 reviewed Nov 28, 2023

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2023

openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Nov 28, 2023

alebedev87 changed the title ~~NO-JIRA: catch up with CI: rename controller's credentialsrequest to minify version~~ OCPBUGS-24040: catch up with CI: rename controller's credentialsrequest to minify version Nov 28, 2023

openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 28, 2023

openshift-ci bot removed docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Nov 28, 2023

alebedev87 changed the title ~~OCPBUGS-24040: catch up with CI: rename controller's credentialsrequest to minify version~~ catch up with CI: rename controller's credentialsrequest to minify version Nov 28, 2023

openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR qe-approved Signifies that QE has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Nov 28, 2023

openshift-merge-bot bot merged commit 2213859 into openshift:release-1.0 Nov 28, 2023
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

catch up with CI: rename controller's credentialsrequest to minify version #120

catch up with CI: rename controller's credentialsrequest to minify version #120

alebedev87 commented Nov 14, 2023 •

edited

Loading

alebedev87 commented Nov 14, 2023

openshift-ci bot commented Nov 14, 2023

alebedev87 commented Nov 14, 2023

alebedev87 commented Nov 14, 2023 •

edited

Loading

openshift-ci-robot commented Nov 14, 2023

alebedev87 commented Nov 14, 2023

alebedev87 commented Nov 15, 2023

alebedev87 commented Nov 15, 2023

alebedev87 commented Nov 15, 2023

alebedev87 commented Nov 22, 2023

openshift-ci bot commented Nov 22, 2023

gcs278 commented Nov 28, 2023

gcs278 Nov 28, 2023

alebedev87 Nov 28, 2023

gcs278 commented Nov 28, 2023

openshift-ci bot commented Nov 28, 2023

alebedev87 commented Nov 28, 2023

openshift-ci bot commented Nov 28, 2023

alebedev87 commented Nov 28, 2023

openshift-ci bot commented Nov 28, 2023

openshift-ci-robot commented Nov 28, 2023

alebedev87 commented Nov 28, 2023

alebedev87 commented Nov 28, 2023

openshift-ci-robot commented Nov 28, 2023

alebedev87 commented Nov 28, 2023

openshift-ci-robot commented Nov 28, 2023

alebedev87 commented Nov 28, 2023

openshift-ci-robot commented Nov 28, 2023

openshift-ci-robot commented Nov 28, 2023

alebedev87 commented Nov 28, 2023

catch up with CI: rename controller's credentialsrequest to minify version #120

catch up with CI: rename controller's credentialsrequest to minify version #120

Conversation

alebedev87 commented Nov 14, 2023 • edited Loading

alebedev87 commented Nov 14, 2023

openshift-ci bot commented Nov 14, 2023

alebedev87 commented Nov 14, 2023

alebedev87 commented Nov 14, 2023 • edited Loading

openshift-ci-robot commented Nov 14, 2023

alebedev87 commented Nov 14, 2023

alebedev87 commented Nov 15, 2023

alebedev87 commented Nov 15, 2023

alebedev87 commented Nov 15, 2023

alebedev87 commented Nov 22, 2023

openshift-ci bot commented Nov 22, 2023

gcs278 commented Nov 28, 2023

gcs278 Nov 28, 2023

Choose a reason for hiding this comment

alebedev87 Nov 28, 2023

Choose a reason for hiding this comment

gcs278 commented Nov 28, 2023

openshift-ci bot commented Nov 28, 2023

alebedev87 commented Nov 28, 2023

openshift-ci bot commented Nov 28, 2023

alebedev87 commented Nov 28, 2023

openshift-ci bot commented Nov 28, 2023

openshift-ci-robot commented Nov 28, 2023

alebedev87 commented Nov 28, 2023

alebedev87 commented Nov 28, 2023

openshift-ci-robot commented Nov 28, 2023

alebedev87 commented Nov 28, 2023

openshift-ci-robot commented Nov 28, 2023

alebedev87 commented Nov 28, 2023

openshift-ci-robot commented Nov 28, 2023

openshift-ci-robot commented Nov 28, 2023

alebedev87 commented Nov 28, 2023

alebedev87 commented Nov 14, 2023 •

edited

Loading

alebedev87 commented Nov 14, 2023 •

edited

Loading