Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: amend irqbalance tests to check IRQBALANCE_BANNED_CPUS #1165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: amend irqbalance tests to check IRQBALANCE_BANNED_CPUS #1165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/e2e/performanceprofile/functests/1_performance/irqbalance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ func getIrqBalanceBannedCPUs(ctx context.Context, node *corev1.Node) (cpuset.CPU
bannedCPUs := unquote(strings.TrimSpace(items[1]))
testlog.Infof("banned CPUs: %q", bannedCPUs)

banned, err := components.CPUMaskToCPUSet(bannedCPUs)
banned, err := cpuset.Parse(bannedCPUs)
if err != nil {
return cpuset.New(), fmt.Errorf("failed to parse the banned CPUs: %v", err)
}
Expand All @@ -359,7 +359,7 @@ func findIrqBalanceBannedCPUsVarFromConf(conf string) string {
if strings.HasPrefix(line, "#") {
continue
}
if !strings.HasPrefix(line, "IRQBALANCE_BANNED_CPUS") {
if !strings.HasPrefix(line, "IRQBALANCE_BANNED_CPULIST") {
Copy link
Contributor

@mrniranjan mrniranjan Sep 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change alone sufficient, because the CPULIST now contains the list where as the IRQBALANCE_BANNED_CPUS was mask ?,

continue
}
return line
Expand Down